Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add excel string to cli and standardize #231

Merged
merged 1 commit into from
Jan 23, 2018
Merged

Add excel string to cli and standardize #231

merged 1 commit into from
Jan 23, 2018

Conversation

juanjoDiaz
Copy link
Collaborator

I noticed that the excelString option was missing from the cli.

Also, noticed that --default-value and --double-quotes where not following the commander convention (hyphen-separated words).
No other change is required since commander automatically parses those as defaulValue and doubleQuotes.

@knownasilya knownasilya merged commit 421baad into zemirco:master Jan 23, 2018
@knownasilya
Copy link
Collaborator

Good work 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8da9876 on juanjoDiaz:improvement/add_excel_strings_to_cli into e6a64ec on zemirco:master.

1 similar comment
@coveralls
Copy link

coveralls commented Jan 23, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 8da9876 on juanjoDiaz:improvement/add_excel_strings_to_cli into e6a64ec on zemirco:master.

@juanjoDiaz juanjoDiaz deleted the improvement/add_excel_strings_to_cli branch February 4, 2018 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juanjoDiaz @knownasilya @coveralls