Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): pass BOM cli option to function #193

Merged
merged 1 commit into from
Aug 3, 2017
Merged

fix(cli): pass BOM cli option to function #193

merged 1 commit into from
Aug 3, 2017

Conversation

rubillionaire
Copy link
Contributor

  • program.withBom is where commander stores the --with-bom option, instead of withBOM, which is the functions internal representation of this option.

@rubillionaire
fix(cli): pass BOM cli option to function
feb5346 
+ program.withBom is where commander stores the --with-bom option, instead of withBOM, which is the functions internal representation of this option.
@coveralls
Copy link

coveralls commented Aug 3, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling feb5346 on rubillionaire:master into 2d8f13b on zemirco:master.

@knownasilya knownasilya merged commit 70cfdfe into zemirco:master Aug 3, 2017
@knownasilya
Copy link
Collaborator

Thanks for catching and fixing! Much appreciated.

@AuroreM
Copy link
Contributor

AuroreM commented Aug 11, 2017

@rubillionaire Thanks for catching this :)

@knownasilya
Copy link
Collaborator

v3.11.1 published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rubillionaire @coveralls @knownasilya @AuroreM