Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Permission settings in web interface should be a bit more "fuzzy" #148

Closed
1 of 4 tasks
voxain opened this issue Aug 6, 2020 · 5 comments
Closed
1 of 4 tasks
Assignees
Labels
enhancement New feature or request web-frontend

Comments

@voxain
Copy link
Contributor

voxain commented Aug 6, 2020

Type of Bug

  • Typo
  • Minor
  • Major
  • Crash

Description

When I tried to add permissions for my guild (435444862972592129) from the webinterface, it didn't apply the permissions or update anything. Using the sp!perms command in chat showed the same result.
There are no errors in the DevTools console.
Adding the permissions via the chat command (sp!perms +sp.guild.mod.mute Moderator) worked perfectly and was displayed correctly both in the sp!perms overview and in the webinterface.

I can imagine that it has to do with how you select the role that you want to assign the permissions to. I tried both entering the name and the ID, both resulting in the same error. Maybe it'd be a good idea to make it a dropdown there aswell, like for the autorole settings?

Steps to Reproduce

Described above

Images and Logs

image


EDIT:

This issue is transformed to enhance the permission setting input which should be more "fuzzy", so it is case insensitive and also accepts pure role IDs.

@voxain voxain added the bug Something isn't working label Aug 6, 2020
@zekroTJA
Copy link
Owner

zekroTJA commented Aug 6, 2020

As I assume from the screenshot, you used the ID of the role, right?

Actually, the field is ment to be used with role names and also has an "autocomplete" function to pick roles.
kJxPuVRXwI

But yeah, actually, it should be possible to also use the role IDs. ^^

@voxain
Copy link
Contributor Author

voxain commented Aug 6, 2020

I have tried using both the Name and ID. However, the autocomplete function doesn't work for me (see screenshot)

I'm on Opera 71 with the following UA: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.26 Safari/537.36 OPR/71.0.3770.0 (Edition developer)

image

@zekroTJA
Copy link
Owner

zekroTJA commented Aug 6, 2020

Try to use lowercase letters, for some reason I#ve missed the lowercasing for that. This is actually an issue I am aware of but was too lazy until now to fix this. :D

@voxain
Copy link
Contributor Author

voxain commented Aug 6, 2020

Ohhh I see! I didn't think about that honestly. Well that's good to know then, it works for me now :)

@voxain voxain closed this as completed Aug 6, 2020
@zekroTJA zekroTJA changed the title [BUG] Permission settings don't work in the webinterface [BUG] Permission settings in web interface should be a bit more "fuzzy" Aug 6, 2020
@zekroTJA zekroTJA added enhancement New feature or request web-frontend and removed bug Something isn't working labels Aug 6, 2020
@zekroTJA
Copy link
Owner

zekroTJA commented Aug 6, 2020

I've transformed the issue to an enhancement issue to improve the permission input in the web interface and added it to the release 1.2 raodmap.

Thanks for the issue anyway. :)

@zekroTJA zekroTJA changed the title [BUG] Permission settings in web interface should be a bit more "fuzzy" [ENHANCEMENT] Permission settings in web interface should be a bit more "fuzzy" Aug 6, 2020
@zekroTJA zekroTJA reopened this Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request web-frontend
Projects
None yet
Development

No branches or pull requests

2 participants