Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove update-check.d.ts #11858

Merged
merged 2 commits into from
Apr 13, 2020
Merged

Remove update-check.d.ts #11858

merged 2 commits into from
Apr 13, 2020
+1 −2

Conversation

matamatanot
Copy link
Contributor

ref:#11815

vscode

@ijjk
Copy link
Member

ijjk commented Apr 13, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary matamatanot/next.js remove-update-check-types Change
buildDuration 10.4s 10.7s ⚠️ +260ms
nodeModulesSize 61 MB 61 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary matamatanot/next.js remove-update-check-types Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..a4ac.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary matamatanot/next.js remove-update-check-types Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary matamatanot/next.js remove-update-check-types Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary matamatanot/next.js remove-update-check-types Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary matamatanot/next.js remove-update-check-types Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary matamatanot/next.js remove-update-check-types Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary matamatanot/next.js remove-update-check-types Change
index.html gzip 925 B 925 B ✓
link.html gzip 934 B 934 B ✓
withRouter.html gzip 920 B 920 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary matamatanot/next.js remove-update-check-types Change
buildDuration 11.5s 11.7s ⚠️ +136ms
nodeModulesSize 61 MB 61 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary matamatanot/next.js remove-update-check-types Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..a4ac.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary matamatanot/next.js remove-update-check-types Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary matamatanot/next.js remove-update-check-types Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary matamatanot/next.js remove-update-check-types Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary matamatanot/next.js remove-update-check-types Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary matamatanot/next.js remove-update-check-types Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary matamatanot/next.js remove-update-check-types Change
_error.js gzip 233 kB 233 kB -485 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 956 B 956 B ✓
index.js gzip 233 kB 233 kB ⚠️ +295 B
link.js gzip 243 kB 243 kB -256 B
routerDirect.js gzip 241 kB 241 kB -20 B
withRouter.js gzip 241 kB 241 kB -31 B
Overall change 1.19 MB 1.19 MB -497 B

@Timer Timer added this to the 9.3.5 milestone Apr 13, 2020
@Timer Timer merged commit 7dbdf1d into vercel:canary Apr 13, 2020
This was referenced Apr 17, 2020
Merged
Merged
Closed
@matamatanot matamatanot deleted the remove-update-check-types branch April 26, 2020 16:22
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.3.5
Development

Successfully merging this pull request may close these issues.
3 participants
@matamatanot @ijjk @Timer