Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sentry example #11701

Merged
merged 3 commits into from
Apr 13, 2020
Merged

Update sentry example #11701

merged 3 commits into from
Apr 13, 2020
+32 −21

Conversation

a14m
Copy link
Contributor

@a14m a14m commented Apr 6, 2020 •
edited
Loading

Fix the with-sentry-simple example configuration code and upload the source maps during build time so that the reported errors show correctly instead of showing the uglify version of the code.

Fixes #8873
Fixes #11642
Fixes #11632

@a14m a14m requested review from lfades and Timer as code owners April 6, 2020 16:32
@ijjk
Copy link
Member

ijjk commented Apr 6, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary a14m/next.js bug/sentry-integration Change
buildDuration 9.9s 9.8s -137ms
nodeModulesSize 47.7 MB 47.7 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary a14m/next.js bug/sentry-integration Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e3d8.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary a14m/next.js bug/sentry-integration Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary a14m/next.js bug/sentry-integration Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary a14m/next.js bug/sentry-integration Change
index.html gzip 918 B 918 B ✓
link.html gzip 927 B 927 B ✓
withRouter.html gzip 914 B 914 B ✓
Overall change 2.76 kB 2.76 kB ✓
Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary a14m/next.js bug/sentry-integration Change
buildDuration 10.1s 10.1s ⚠️ +48ms
nodeModulesSize 47.7 MB 47.7 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary a14m/next.js bug/sentry-integration Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e3d8.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary a14m/next.js bug/sentry-integration Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary a14m/next.js bug/sentry-integration Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_error.js gzip 233 kB 233 kB -302 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 957 B 957 B ✓
index.js gzip 233 kB 233 kB -124 B
link.js gzip 243 kB 243 kB -36 B
routerDirect.js gzip 241 kB 241 kB ⚠️ +95 B
withRouter.js gzip 241 kB 241 kB ⚠️ +5 B
Overall change 1.19 MB 1.19 MB -362 B

@ijjk
Copy link
Member

ijjk commented Apr 6, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary a14m/next.js bug/sentry-integration Change
buildDuration 10.5s 10.5s -29ms
nodeModulesSize 47.7 MB 47.7 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary a14m/next.js bug/sentry-integration Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e3d8.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary a14m/next.js bug/sentry-integration Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary a14m/next.js bug/sentry-integration Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary a14m/next.js bug/sentry-integration Change
index.html gzip 918 B 918 B ✓
link.html gzip 927 B 927 B ✓
withRouter.html gzip 914 B 914 B ✓
Overall change 2.76 kB 2.76 kB ✓
Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary a14m/next.js bug/sentry-integration Change
buildDuration 11.2s 11.2s -59ms
nodeModulesSize 47.7 MB 47.7 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary a14m/next.js bug/sentry-integration Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e3d8.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary a14m/next.js bug/sentry-integration Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary a14m/next.js bug/sentry-integration Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_error.js gzip 233 kB 233 kB -3 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 957 B 957 B ✓
index.js gzip 233 kB 233 kB ⚠️ +336 B
link.js gzip 243 kB 243 kB -88 B
routerDirect.js gzip 241 kB 241 kB -115 B
withRouter.js gzip 241 kB 241 kB ⚠️ +300 B
Overall change 1.19 MB 1.19 MB ⚠️ +430 B

@ijjk
Copy link
Member

ijjk commented Apr 7, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary a14m/next.js bug/sentry-integration Change
buildDuration 10.5s 10.6s ⚠️ +115ms
nodeModulesSize 47.7 MB 47.7 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary a14m/next.js bug/sentry-integration Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e3d8.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary a14m/next.js bug/sentry-integration Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary a14m/next.js bug/sentry-integration Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary a14m/next.js bug/sentry-integration Change
index.html gzip 916 B 916 B ✓
link.html gzip 925 B 925 B ✓
withRouter.html gzip 914 B 914 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary a14m/next.js bug/sentry-integration Change
buildDuration 11.3s 11.6s ⚠️ +230ms
nodeModulesSize 47.7 MB 47.7 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary a14m/next.js bug/sentry-integration Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e3d8.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary a14m/next.js bug/sentry-integration Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary a14m/next.js bug/sentry-integration Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_error.js gzip 233 kB 233 kB -248 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 956 B 956 B ✓
index.js gzip 233 kB 233 kB -274 B
link.js gzip 243 kB 243 kB ⚠️ +1 B
routerDirect.js gzip 241 kB 241 kB ⚠️ +26 B
withRouter.js gzip 241 kB 241 kB -340 B
Overall change 1.19 MB 1.19 MB -835 B

@ijjk
Copy link
Member

ijjk commented Apr 7, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary a14m/next.js bug/sentry-integration Change
buildDuration 9.4s 9.3s -39ms
nodeModulesSize 47.7 MB 47.7 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary a14m/next.js bug/sentry-integration Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e3d8.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary a14m/next.js bug/sentry-integration Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary a14m/next.js bug/sentry-integration Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary a14m/next.js bug/sentry-integration Change
index.html gzip 916 B 916 B ✓
link.html gzip 925 B 925 B ✓
withRouter.html gzip 914 B 914 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary a14m/next.js bug/sentry-integration Change
buildDuration 10.3s 10s -327ms
nodeModulesSize 47.7 MB 47.7 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary a14m/next.js bug/sentry-integration Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e3d8.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary a14m/next.js bug/sentry-integration Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary a14m/next.js bug/sentry-integration Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_error.js gzip 233 kB 233 kB ⚠️ +300 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 956 B 956 B ✓
index.js gzip 233 kB 233 kB -18 B
link.js gzip 243 kB 243 kB ⚠️ +7 B
routerDirect.js gzip 241 kB 241 kB -147 B
withRouter.js gzip 241 kB 241 kB ⚠️ +57 B
Overall change 1.19 MB 1.19 MB ⚠️ +199 B

@timneutkens timneutkens added the examples Issue/PR related to examples label Apr 7, 2020
@a14m
Copy link
Contributor Author

a14m commented Apr 7, 2020

as per the comment mentioned here: #8873 (comment) it still have issues with SSR as node js doesn't seem to respect source maps

@ijjk
Copy link
Member

ijjk commented Apr 9, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary a14m/next.js bug/sentry-integration Change
buildDuration 11.6s 11.6s -50ms
nodeModulesSize 61 MB 61 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary a14m/next.js bug/sentry-integration Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e3d8.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary a14m/next.js bug/sentry-integration Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary a14m/next.js bug/sentry-integration Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary a14m/next.js bug/sentry-integration Change
index.html gzip 918 B 918 B ✓
link.html gzip 926 B 926 B ✓
withRouter.html gzip 913 B 913 B ✓
Overall change 2.76 kB 2.76 kB ✓
Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary a14m/next.js bug/sentry-integration Change
buildDuration 12.3s 12.3s -10ms
nodeModulesSize 61 MB 61 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary a14m/next.js bug/sentry-integration Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e3d8.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary a14m/next.js bug/sentry-integration Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary a14m/next.js bug/sentry-integration Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary a14m/next.js bug/sentry-integration Change
_error.js gzip 233 kB 233 kB ⚠️ +38 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 956 B 956 B ✓
index.js gzip 233 kB 233 kB ⚠️ +22 B
link.js gzip 243 kB 243 kB ⚠️ +318 B
routerDirect.js gzip 241 kB 241 kB -3 B
withRouter.js gzip 241 kB 241 kB ⚠️ +366 B
Overall change 1.19 MB 1.19 MB ⚠️ +741 B

Timer
Timer approved these changes Apr 13, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Timer Timer added this to the 9.3.5 milestone Apr 13, 2020
@Timer Timer changed the title Bug/sentry simple example not working Update sentry example Apr 13, 2020
@Timer Timer merged commit 0ccce72 into vercel:canary Apr 13, 2020
@a14m
Copy link
Contributor Author

a14m commented Apr 13, 2020

Thanks for merging, there’s still some issue with the SSR not showing the error correctly, but this definitely fixes the client side reporting at least, I’ll update the code in a separate PR if I managed to figure out the issue with SSR (also mentioned in this issue UnlyEd/next-right-now#28)

This was referenced Apr 17, 2020
Merged
Merged
Closed
@a14m a14m deleted the bug/sentry-integration branch June 2, 2020 18:07
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
9.3.5
Development

Successfully merging this pull request may close these issues.

with-sentry-simple source maps not showing on sentry Source maps info don't show in with-sentry example
4 participants
@a14m @ijjk @Timer @timneutkens