Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated with-webpack-bundle-size-analyzer to use SSG #11657

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Updated with-webpack-bundle-size-analyzer to use SSG #11657

merged 2 commits into from
Apr 7, 2020

Conversation

djanda97
Copy link
Contributor

@djanda97 djanda97 commented Apr 4, 2020

Related to #11014.

@ijjk
Copy link
Member

ijjk commented Apr 4, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
buildDuration 9.7s 9.7s ⚠️ +42ms
nodeModulesSize 47.7 MB 47.7 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5272.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.75 kB 6.75 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
index.html gzip 917 B 917 B ✓
link.html gzip 926 B 926 B ✓
withRouter.html gzip 914 B 914 B ✓
Overall change 2.76 kB 2.76 kB ✓
Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
buildDuration 10.3s 10.3s -7ms
nodeModulesSize 47.7 MB 47.7 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5272.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.75 kB 6.75 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
_error.js gzip 233 kB 233 kB -15 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 956 B 956 B ✓
index.js gzip 233 kB 233 kB ⚠️ +36 B
link.js gzip 243 kB 243 kB -157 B
routerDirect.js gzip 241 kB 241 kB ⚠️ +7 B
withRouter.js gzip 241 kB 241 kB -57 B
Overall change 1.19 MB 1.19 MB -186 B

@timneutkens timneutkens added the examples Issue/PR related to examples label Apr 6, 2020
lfades
lfades requested changes Apr 6, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my suggestions

lfades
lfades reviewed Apr 6, 2020
View reviewed changes
examples/with-webpack-bundle-size-analyzer/pages/contact.js Outdated
@@ -1 +0,0 @@
export default () => <div>This is the contact page.</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this page removed? I think it's good to have a simple page like this to show its output in the bundle analyzer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the page because I didn't see it used anywhere in the application, but I wasn't thinking of it in the context of this example. It makes sense now that it is used to show its output in the bundle analyzer.

@ijjk
Copy link
Member

ijjk commented Apr 7, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
buildDuration 11.2s 11.5s ⚠️ +301ms
nodeModulesSize 47.7 MB 47.7 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e3d8.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
index.html gzip 916 B 916 B ✓
link.html gzip 925 B 925 B ✓
withRouter.html gzip 914 B 914 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
buildDuration 12s 12.1s ⚠️ +67ms
nodeModulesSize 47.7 MB 47.7 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e3d8.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary djanda97/next.js update-with-webpack-bundle-size-analyzer Change
_error.js gzip 233 kB 233 kB ✓
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 956 B 956 B ✓
index.js gzip 233 kB 233 kB -68 B
link.js gzip 243 kB 243 kB ⚠️ +163 B
routerDirect.js gzip 241 kB 241 kB -298 B
withRouter.js gzip 241 kB 241 kB ⚠️ +47 B
Overall change 1.19 MB 1.19 MB -156 B

@djanda97 djanda97 requested a review from lfades April 7, 2020 00:34
lfades
lfades approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lfades lfades merged commit 44b7b3c into vercel:canary Apr 7, 2020
This was referenced Apr 17, 2020
Merged
Merged
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfades lfades lfades approved these changes

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djanda97 @ijjk @lfades @timneutkens