Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable caching for react@next workflow as its not supported #10331

Merged
merged 4 commits into from
Jan 30, 2020
Merged

Disable caching for react@next workflow as its not supported #10331

merged 4 commits into from
Jan 30, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jan 30, 2020

We currently can't use actions/cache to re-use a build step for our scheduled react@next tests since the actions/cache step isn't supported for scheduled jobs in GitHub actions

[warning]Event Validation Error: The event type schedule is not supported. Only push, pull_request events are supported at this time.

@ijjk ijjk added this to the 9.2.2 milestone Jan 30, 2020
@ijjk
Copy link
Member Author

ijjk commented Jan 30, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary ijjk/next.js tests/react-next-cache Change
buildDuration 11.1s 11.2s ⚠️ +83ms
nodeModulesSize 52.1 MB 52.1 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js tests/react-next-cache Change
main-HASH.js gzip 5.1 kB 5.1 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..d6ae.js gzip 16.2 kB 16.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 69.9 kB 69.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js tests/react-next-cache Change
main-HASH.module.js gzip 4.1 kB 4.1 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 15.1 kB 15.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 64.6 kB 64.6 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js tests/react-next-cache Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js tests/react-next-cache Change
_app.js gzip 1.15 kB 1.15 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.68 kB 9.68 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js tests/react-next-cache Change
_app.module.js gzip 576 B 576 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.22 kB 7.22 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js tests/react-next-cache Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js tests/react-next-cache Change
index.html gzip 1.02 kB 1.02 kB ✓
link.html gzip 1.03 kB 1.03 kB ✓
withRouter.html gzip 1.02 kB 1.02 kB ✓
Overall change 3.07 kB 3.07 kB ✓
Serverless Mode
General
zeit/next.js canary ijjk/next.js tests/react-next-cache Change
buildDuration 11.6s 11.4s -247ms
nodeModulesSize 52.1 MB 52.1 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js tests/react-next-cache Change
main-HASH.js gzip 5.1 kB 5.1 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..d6ae.js gzip 16.2 kB 16.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 69.9 kB 69.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js tests/react-next-cache Change
main-HASH.module.js gzip 4.1 kB 4.1 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 15.1 kB 15.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 64.6 kB 64.6 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js tests/react-next-cache Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js tests/react-next-cache Change
_app.js gzip 1.15 kB 1.15 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.68 kB 9.68 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js tests/react-next-cache Change
_app.module.js gzip 576 B 576 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.22 kB 7.22 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js tests/react-next-cache Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary ijjk/next.js tests/react-next-cache Change
_error.js gzip 46.6 kB 46.6 kB ✓
404.html gzip 1.42 kB 1.42 kB ✓
hooks.html gzip 1.05 kB 1.05 kB ✓
index.js gzip 46.8 kB 46.8 kB ✓
link.js gzip 72.4 kB 72.4 kB ✓
routerDirect.js gzip 70.4 kB 70.4 kB ✓
withRouter.js gzip 70.4 kB 70.4 kB ✓
Overall change 309 kB 309 kB ✓

Commit: 8fdc096

@ijjk ijjk marked this pull request as ready for review January 30, 2020 01:32
@ijjk ijjk requested a review from Timer as a code owner January 30, 2020 01:32
@Timer Timer merged commit e6f401c into vercel:canary Jan 30, 2020
@Timer Timer deleted the tests/react-next-cache branch January 30, 2020 05:14
chibicode pushed a commit to chibicode/next.js that referenced this pull request Feb 11, 2020
@ijjk @chibicode
Disable caching for react@next workflow as its not supported (vercel#…
06be851 
…10331)

* Disable caching for react@next workflow as its not support

* Disable needs build

* Also add checkout step

* Remove running on pull_request from testing
This was referenced Mar 13, 2020
Closed
Open
This was referenced Mar 22, 2020
Merged
Merged
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @Timer