show_completion_documentation = false removes slash command descriptions

[notpeter]

Check for existing issues

• Completed

Describe the bug / provide steps to reproduce it

Steps to reproduce:

1. Add "show_completion_documentation": false, to your Zed User settings.
2. Open an assistant panel.
3. Type /

I don't know whether this is intended behavior.
I assume it just an accidental setting/style re-use.

Environment

Zed: v0.163.0 (Zed Nightly d92166f)
OS: macOS 14.7.0
Memory: 64 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

Default:

show_completion_documentation false in settings.

If applicable, attach your Zed.log file to this issue.

N/A

[mgsloan]

I imagine this could be resolved via a special-case. However, a more consistent way for it to be resolved might be:

• Add "Assistant" as a language.
• Make show_completion_documentation a LanguageSetting. I have a PR for this in Add per-language settings show_completions_on_input and show_completion_documentation #21722 since it seems like a nice thing regardless of this particular issue.
• Have default settings for "Assistant" language set show_completion_documentation = true.

Not entirely sure if this is desirable / what the ramifications are. One issue with this is that slash completion appears to be active even when in other languages (such as a markdown code block that specifies a language).

[nicholaswmin]

I have this issue with code snippets - I think show_code_completion_documentation shouldn't affect the description; if you don't want a description simply don't define one:

  "await sleep": {
    "description": "add async delay", <-- // dont define this
    "prefix": ["sleep", "wait", "delay", "timeout"],  
    "body": "await new Promise(r => setTimeout(r, ${0}))"
  },

The completion documentation is super clunky for me but the inline-description is just as clunky as its turned on as when it's turned off