Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting incorrect in ui.markdown with markdown2==2.4.11 #2153

Closed
thetableman opened this issue Dec 11, 2023 · 1 comment · Fixed by #2154
Closed

Formatting incorrect in ui.markdown with markdown2==2.4.11 #2153

thetableman opened this issue Dec 11, 2023 · 1 comment · Fixed by #2154
Labels
bug Something isn't working
Milestone

Comments

@thetableman
Copy link
Contributor

Description

I recently created a new venv and found that the text output of ui.markdown suddenly displayed incorrectly with an exisiting project. It seems when installing NiceGUI from pip the new venv grabbed markdown2==2.4.11 whereas the previous was 2.4.10.

from nicegui import ui

ui.markdown('''Test **Markdown**.  
                **over** multiple lines.''')

ui.run

With markdown2==2.4.10
image

With markdown2==2.4.11
image

The issue seems to arise when a new line starts with markdown identifiers.

@falkoschindler
Copy link
Contributor

Thanks for the bug report, @thetableman!
There is an upstream bug trentm/python-markdown2#546 which has already been fixed. Until it gets released, we should indeed apply your PR #2154. 👍

@falkoschindler falkoschindler linked a pull request Dec 11, 2023 that will close this issue
@falkoschindler falkoschindler added the bug Something isn't working label Dec 11, 2023
@falkoschindler falkoschindler added this to the 1.4.6 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants