From df8a89e16080b53b9b59f3ff8c6eba1cb1fa750a Mon Sep 17 00:00:00 2001
From: Vincenzo Selvaggio <vselvaggio@hotmail.it>
Date: Wed, 5 Nov 2014 10:34:15 +0000
Subject: [PATCH] added pmml version to pmml model changed the copyright to
 spark

---
 .../mllib/export/pmml/PMMLModelExport.scala   | 39 ++++++++-----------
 1 file changed, 16 insertions(+), 23 deletions(-)

diff --git a/mllib/src/main/scala/org/apache/spark/mllib/export/pmml/PMMLModelExport.scala b/mllib/src/main/scala/org/apache/spark/mllib/export/pmml/PMMLModelExport.scala
index f18f9cee8ea05..665eff71644ad 100644
--- a/mllib/src/main/scala/org/apache/spark/mllib/export/pmml/PMMLModelExport.scala
+++ b/mllib/src/main/scala/org/apache/spark/mllib/export/pmml/PMMLModelExport.scala
@@ -17,46 +17,39 @@
 
 package org.apache.spark.mllib.export.pmml
 
-import org.apache.spark.mllib.export.ModelExport
-import java.io.OutputStream
-import org.jpmml.model.JAXBUtil
-import org.dmg.pmml.PMML
-import javax.xml.transform.stream.StreamResult
+import java.text.SimpleDateFormat
+import java.util.Date
+
 import scala.beans.BeanProperty
+
 import org.dmg.pmml.Application
-import org.dmg.pmml.Timestamp
 import org.dmg.pmml.Header
-import java.text.SimpleDateFormat
-import java.util.Date
+import org.dmg.pmml.PMML
+import org.dmg.pmml.Timestamp
+
+import org.apache.spark.mllib.export.ModelExport
 
-trait PMMLModelExport extends ModelExport{
+private[mllib] trait PMMLModelExport extends ModelExport{
   
   /**
    * Holder of the exported model in PMML format
    */
   @BeanProperty
-  var pmml: PMML = new PMML();
+  val pmml: PMML = new PMML();
 
   setHeader(pmml);
   
   private def setHeader(pmml : PMML): Unit = {
-    var version = getClass().getPackage().getImplementationVersion()
-    var app = new Application().withName("Apache Spark MLlib").withVersion(version)
-    var timestamp = new Timestamp()
+    val version = getClass().getPackage().getImplementationVersion()
+    val app = new Application().withName("Apache Spark MLlib").withVersion(version)
+    val timestamp = new Timestamp()
         .withContent(new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss").format(new Date()))
-    var header = new Header()
-        .withCopyright("www.dmg.org")
+    val header = new Header()
+        .withCopyright("Apache Spark MLlib")
         .withApplication(app)
         .withTimestamp(timestamp);
     pmml.setHeader(header);
+    pmml.setVersion("4.2")
   } 
   
-  /**
-   * Write the exported model (in PMML XML) to the output stream specified 
-   */
-  @Override
-  def save(outputStream: OutputStream): Unit = {
-    JAXBUtil.marshalPMML(pmml, new StreamResult(outputStream));  
-  }
-  
 }