Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Customize db user password keys #213

Open
TheNumenorean opened this issue Sep 24, 2024 · 2 comments
Open

Feature: Customize db user password keys #213

TheNumenorean opened this issue Sep 24, 2024 · 2 comments
Labels
Discussion documentation Improvements or additions to documentation enhancement New feature or request feature new required feature
Milestone

Comments

@TheNumenorean
Copy link
Contributor

Feature Description

Can this value be made configurable?

I want to use existing secrets to populate the db passwords, but the keys are not "geonode-*".

Proposed Solution

Add a configuration to specify geonode.secret.existingSecretName for the postgres, geodata, and geonode users separately, rather than using one for all of them. Then, add a config to specify the key in the secret to receive the password from.

Additional Information

I am using the zalando pgo manually since i want more customization, and need to use the secrets it generates.

@TheNumenorean TheNumenorean added the feature new required feature label Sep 24, 2024
@mwallschlaeger mwallschlaeger added documentation Improvements or additions to documentation enhancement New feature or request Discussion labels Sep 25, 2024
@mwallschlaeger mwallschlaeger added this to the Release 1.2.3 milestone Sep 25, 2024
@mwallschlaeger
Copy link
Contributor

@TheNumenorean i understand your request. Within our setup we're not deploying the postgres-operator using geonode-k8s but still build the database with geonode-k8s. You can do so by setting:

postgres-operator:
  enabled: False
postgres:
  type: operator
  operator:
    storageSize: 2Gi
    numberOfInstances: 1
    postgres_version: 15

find more information on different database setups in geonode-k8s here: #150

Nevertheless we can make the secret name a variable in near future. Would you have time to contribute this as a PR?

@TheNumenorean
Copy link
Contributor Author

That makes sense; specifically what i needed was to add an additional user and database, since i am taking advantage of colocating the data with another app for query purposes. I believe that isn't possible currently when geonode-k8s is creating the database entity, but honestly i think that's fine, given that creating it myself is pretty easy (barring the secret issue).

There is a good chance I can put in a PR, though not for a week at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion documentation Improvements or additions to documentation enhancement New feature or request feature new required feature
Projects
None yet
Development

No branches or pull requests

2 participants