Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: replace getRowTrProps with render prop renderRowTr #753

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

targos
Copy link
Member

@targos targos commented Jul 30, 2024

The previous API was not flexible enough. Sometimes we need to call hooks in the context of the rows.
Now this is possible with the pattern:

renderRowTr={({ row, children }) => {
  return <CustomTr row={row}>{children}</CustomTr>
}}

The previous API was not flexible enough. Sometimes we need to call hooks in the context of the rows.
Now this is possible with the pattern:

```
renderRowTr={({ row, children }) => {
  return <CustomTr row={row}>{children}</CustomTr>
}}
```
Copy link

cloudflare-workers-and-pages bot commented Jul 30, 2024

Deploying react-science with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5ba1943
Status: ✅  Deploy successful!
Preview URL: https://3a6955a6.react-science.pages.dev
Branch Preview URL: https://render-tr.react-science.pages.dev

View logs

Copy link

@tpoisseau tpoisseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@targos targos merged commit 19346d9 into main Jul 31, 2024
12 checks passed
@targos targos deleted the render-tr branch July 31, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants