feat: improve useSelect hook item render #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamed-musallam
changed the title
Deploying react-science with
|
| Latest commit: |
ae4ff19
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b1691700.react-science.pages.dev |
| Branch Preview URL: | https://improve-use-select-hook-item.react-science.pages.dev |
hamed-musallam
force-pushed
the
improve-use-select-hook-item-render
branch
from
3887ed5
to
b7d97cd
Compare
stropitek
approved these changes
May 29, 2024
stropitek
requested changes
Jun 3, 2024
stropitek
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, we need more than just text in the menu items, we require additional elements, as seen in the workspaces dropdown menu in NMRium. Therefore, I suggest enhancing the useSelect hook to support custom item rendering. I don't want to replace the entire MenuItem; I just need the ability to customize its content.