Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modal should not take space in the layout if no nodes inside it #462

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

hamed-musallam
Copy link
Contributor

@hamed-musallam hamed-musallam commented Mar 22, 2023

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e82cf85
Status: ✅  Deploy successful!
Preview URL: https://c162fada.react-science.pages.dev
Branch Preview URL: https://fix-modal-take-space-when-no.react-science.pages.dev

View logs

@targos targos merged commit 7cf740a into main Mar 23, 2023
@targos targos deleted the fix-modal-take-space-when-nothing-in-dialog branch March 23, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants