Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift state up in SplitPane #458

Open
stropitek opened this issue Mar 13, 2023 · 2 comments
Open

Lift state up in SplitPane #458

stropitek opened this issue Mar 13, 2023 · 2 comments

Comments

@stropitek
Copy link
Contributor

We currently have a "semi-controlled" component which I think is an anti-pattern.

We should make SplitPane "controlled", meaning the size which is passed is always the actual size (same for "closed").

The effect which syncs the external configuration's size of the panel and the local state should reside outside of this component.

@hamed-musallam

@stropitek
Copy link
Contributor Author

The semi-controlled pattern I refer to is the one implemented in #457

@hamed-musallam
Copy link
Contributor

I think most of the time, not all end users need to control the size and closed properties but I agree that maybe it is better to lift the state up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants