From 46ed4de3af94210c0331b81081773d9b04dae5cf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com>
Date: Fri, 24 Mar 2023 08:53:01 +0100
Subject: [PATCH] fix: correct modal rendering on Webkit (#466)

---
 package-lock.json                     | 26 +++++++++++++-------------
 package.json                          |  4 ++--
 src/components/modal/ConfirmModal.tsx |  2 --
 src/components/modal/Modal.tsx        |  2 --
 4 files changed, 15 insertions(+), 19 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index fcfc40bb..362e2a1b 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -6,7 +6,7 @@
   "packages": {
     "": {
       "name": "react-science",
-      "version": "0.21.0",
+      "version": "0.21.1",
       "license": "MIT",
       "dependencies": {
         "@emotion/react": "^11.10.6",
@@ -15,12 +15,12 @@
         "@lukeed/uuid": "^2.0.0",
         "@popperjs/core": "^2.11.6",
         "@tanstack/react-query": "^4.28.0",
-        "@tanstack/react-table": "^8.7.9",
+        "@tanstack/react-table": "^8.8.0",
         "biologic-converter": "^0.6.0",
         "cheminfo-types": "^1.4.0",
         "d3-scale-chromatic": "^3.0.0",
         "filelist-utils": "^1.8.0",
-        "immer": "^9.0.19",
+        "immer": "^9.0.21",
         "jcampconverter": "^9.1.0",
         "lodash": "^4.17.21",
         "ml-gsd": "^12.1.2",
@@ -1611,11 +1611,11 @@
       }
     },
     "node_modules/@tanstack/react-table": {
-      "version": "8.7.9",
-      "resolved": "https://registry.npmjs.org/@tanstack/react-table/-/react-table-8.7.9.tgz",
-      "integrity": "sha512-6MbbQn5AupSOkek1+6IYu+1yZNthAKTRZw9tW92Vi6++iRrD1GbI3lKTjJalf8lEEKOqapPzQPE20nywu0PjCA==",
+      "version": "8.8.0",
+      "resolved": "https://registry.npmjs.org/@tanstack/react-table/-/react-table-8.8.0.tgz",
+      "integrity": "sha512-K55peZ4VNRA+Jk/rSI8+0Tj/T9q8SyysmnK08wO/5kgIX3MhGL7wl0858eEcvd/2eq+CPPmhQx9wYoWOWtFEhg==",
       "dependencies": {
-        "@tanstack/table-core": "8.7.9"
+        "@tanstack/table-core": "8.8.0"
       },
       "engines": {
         "node": ">=12"
@@ -1630,9 +1630,9 @@
       }
     },
     "node_modules/@tanstack/table-core": {
-      "version": "8.7.9",
-      "resolved": "https://registry.npmjs.org/@tanstack/table-core/-/table-core-8.7.9.tgz",
-      "integrity": "sha512-4RkayPMV1oS2SKDXfQbFoct1w5k+pvGpmX18tCXMofK/VDRdA2hhxfsQlMvsJ4oTX8b0CI4Y3GDKn5T425jBCw==",
+      "version": "8.8.0",
+      "resolved": "https://registry.npmjs.org/@tanstack/table-core/-/table-core-8.8.0.tgz",
+      "integrity": "sha512-P8Vk9yngfai1GLEfyqtT0b+Dty8subPR8yl5r1z/z4Z8NtaCIL1n+OmMV1QBU8WojeSSsWgr+o1CTxnaaOBoyQ==",
       "engines": {
         "node": ">=12"
       },
@@ -5525,9 +5525,9 @@
       "integrity": "sha512-XXOFtyqDjNDAQxVfYxuF7g9Il/IbWmmlQg2MYKOH8ExIT1qg6xc4zyS3HaEEATgs1btfzxq15ciUiY7gjSXRGQ=="
     },
     "node_modules/immer": {
-      "version": "9.0.19",
-      "resolved": "https://registry.npmjs.org/immer/-/immer-9.0.19.tgz",
-      "integrity": "sha512-eY+Y0qcsB4TZKwgQzLaE/lqYMlKhv5J9dyd2RhhtGhNo2njPXDqU9XPfcNfa3MIDsdtZt5KlkIsirlo4dHsWdQ==",
+      "version": "9.0.21",
+      "resolved": "https://registry.npmjs.org/immer/-/immer-9.0.21.tgz",
+      "integrity": "sha512-bc4NBHqOqSfRW7POMkHd51LvClaeMXpm8dx0e8oE2GORbq5aRK7Bxl4FyzVLdGtLmvLKL7BTDBG5ACQm4HWjTA==",
       "funding": {
         "type": "opencollective",
         "url": "https://opencollective.com/immer"
diff --git a/package.json b/package.json
index a1cb4f0d..ee7f0834 100644
--- a/package.json
+++ b/package.json
@@ -67,12 +67,12 @@
     "@lukeed/uuid": "^2.0.0",
     "@popperjs/core": "^2.11.6",
     "@tanstack/react-query": "^4.28.0",
-    "@tanstack/react-table": "^8.7.9",
+    "@tanstack/react-table": "^8.8.0",
     "biologic-converter": "^0.6.0",
     "cheminfo-types": "^1.4.0",
     "d3-scale-chromatic": "^3.0.0",
     "filelist-utils": "^1.8.0",
-    "immer": "^9.0.19",
+    "immer": "^9.0.21",
     "jcampconverter": "^9.1.0",
     "lodash": "^4.17.21",
     "ml-gsd": "^12.1.2",
diff --git a/src/components/modal/ConfirmModal.tsx b/src/components/modal/ConfirmModal.tsx
index 8fb99035..ae63ee29 100644
--- a/src/components/modal/ConfirmModal.tsx
+++ b/src/components/modal/ConfirmModal.tsx
@@ -21,7 +21,6 @@ interface ConfirmModalProps {
 }
 
 const ConfirmModalDialog = styled.dialog`
-  position: fixed;
   background-color: transparent;
 
   ::backdrop {
@@ -36,7 +35,6 @@ const ConfirmModalContents = styled.div<{
   display: flex;
   flex-direction: column;
   background-color: white;
-  max-height: 90%;
   width: 100%;
   border-width: 1px;
   border-color: transparent;
diff --git a/src/components/modal/Modal.tsx b/src/components/modal/Modal.tsx
index 5c00939a..a60fcd2c 100644
--- a/src/components/modal/Modal.tsx
+++ b/src/components/modal/Modal.tsx
@@ -19,7 +19,6 @@ export interface ModalProps {
 }
 
 const DialogRoot = styled.dialog`
-  position: fixed;
   background-color: transparent;
 
   ::backdrop {
@@ -32,7 +31,6 @@ const DialogContents = styled.div`
   display: flex;
   flex-direction: column;
   background-color: white;
-  max-height: 90%;
   border-width: 1px;
   border-color: transparent;
   border-radius: 0.5rem;