Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: customize measurement stroke color #358

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

stropitek
Copy link
Contributor

Ref: #313

@stropitek stropitek linked an issue Nov 15, 2022 that may be closed by this pull request
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 15, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e87455f
Status: ✅  Deploy successful!
Preview URL: https://e508b75e.analysis-ui-components.pages.dev
Branch Preview URL: https://313-color-selection-in-measu.analysis-ui-components.pages.dev

View logs

@stropitek stropitek force-pushed the 313-color-selection-in-measurement-preferences-panel branch from 95503a4 to 7434abb Compare November 15, 2022 09:18
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2022

Codecov Report

Base: 88.01% // Head: 88.01% // No change to project coverage 👍

Coverage data is based on head (e87455f) compared to base (e419707).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #358   +/-   ##
=======================================
  Coverage   88.01%   88.01%           
=======================================
  Files          12       12           
  Lines         868      868           
  Branches      133      133           
=======================================
  Hits          764      764           
  Misses        104      104           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@targos
Copy link
Member

targos commented Nov 15, 2022

@stropitek Please tell me if you're still working on it, otherwise I'll take it over in 30mins

@targos targos self-assigned this Nov 15, 2022
@stropitek
Copy link
Contributor Author

Not working on it anymore

@targos targos force-pushed the 313-color-selection-in-measurement-preferences-panel branch from 7434abb to e87455f Compare November 15, 2022 14:22
@targos targos merged commit d3c41f8 into main Nov 15, 2022
@targos targos deleted the 313-color-selection-in-measurement-preferences-panel branch November 15, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color selection in measurement preferences panel
3 participants