Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: click echap on fullscreen case #334

Merged
merged 2 commits into from
Nov 11, 2022

Conversation

wadjih-bencheikh18
Copy link
Member

closes #329

@wadjih-bencheikh18 wadjih-bencheikh18 linked an issue Nov 10, 2022 that may be closed by this pull request
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 10, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cb523cd
Status: ✅  Deploy successful!
Preview URL: https://e4ceabc6.analysis-ui-components.pages.dev
Branch Preview URL: https://329-fullscreen-problem-when-.analysis-ui-components.pages.dev

View logs

@codecov-commenter
Copy link

Codecov Report

Base: 88.99% // Head: 88.99% // No change to project coverage 👍

Coverage data is based on head (13849cf) compared to base (78c40dc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #334   +/-   ##
=======================================
  Coverage   88.99%   88.99%           
=======================================
  Files          11       11           
  Lines         845      845           
  Branches      130      130           
=======================================
  Hits          752      752           
  Misses         93       93           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@targos targos merged commit 7365d88 into main Nov 11, 2022
@targos targos deleted the 329-fullscreen-problem-when-exit-with-escape branch November 11, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fullscreen problem when exit with Escape
3 participants