Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add context menu dropdown #317

Merged
merged 4 commits into from
Nov 8, 2022
Merged

feat: add context menu dropdown #317

merged 4 commits into from
Nov 8, 2022

Conversation

Sebastien-Ahkrin
Copy link
Contributor

close: #260

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 4, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f5b0ef2
Status: ✅  Deploy successful!
Preview URL: https://048d3f69.analysis-ui-components.pages.dev
Branch Preview URL: https://feat-context-menu.analysis-ui-components.pages.dev

View logs

@targos
Copy link
Member

targos commented Nov 4, 2022

Can you open it aligned on the top left corner (like the native context menus)?

@codecov-commenter
Copy link

Codecov Report

Base: 91.67% // Head: 89.13% // Decreases project coverage by -2.54% ⚠️

Coverage data is based on head (67c0abf) compared to base (443572a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
- Coverage   91.67%   89.13%   -2.55%     
==========================================
  Files          10       10              
  Lines         757      856      +99     
  Branches      122      129       +7     
==========================================
+ Hits          694      763      +69     
- Misses         63       93      +30     
Impacted Files Coverage Δ
src/app/data/loaders/biologicLoader.ts 73.68% <0.00%> (-11.61%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@targos
Copy link
Member

targos commented Nov 8, 2022

Ping @Sebastien-Ahkrin

@Sebastien-Ahkrin
Copy link
Contributor Author

Ping @Sebastien-Ahkrin

Ups ! I'm now working on it to make it good!

@targos
Copy link
Member

targos commented Nov 8, 2022

Please fix the eslint error, that's what I'm waiting for :)

@targos targos merged commit f71c83c into main Nov 8, 2022
@targos targos deleted the feat-context-menu branch November 8, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a dropdown / contextual menu component
3 participants