Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plot mass with labels #309

Merged
merged 6 commits into from
Nov 4, 2022
Merged

fix: plot mass with labels #309

merged 6 commits into from
Nov 4, 2022

Conversation

lpatiny
Copy link
Contributor

@lpatiny lpatiny commented Nov 2, 2022

No description provided.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 2, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3692c06
Status: ✅  Deploy successful!
Preview URL: https://08020058.analysis-ui-components.pages.dev
Branch Preview URL: https://fixmass.analysis-ui-components.pages.dev

View logs

@lpatiny
Copy link
Contributor Author

lpatiny commented Nov 3, 2022

@wadjih-bencheikh18 Could you take over this PR ?

Need to remove all the xAxis, yAxis if not necessary (everywhere). By default it is x and y and it should be ok.

Please also check the test cases

@wadjih-bencheikh18
Copy link
Member

Need to remove all the xAxis, yAxis

I removed all axisID as mentioned, and updated tests

@wadjih-bencheikh18 wadjih-bencheikh18 marked this pull request as ready for review November 4, 2022 10:46
@targos targos merged commit 1d45352 into main Nov 4, 2022
@targos targos deleted the fixmass branch November 4, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants