Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropDown menu #283

Merged
merged 19 commits into from
Nov 3, 2022
Merged

DropDown menu #283

merged 19 commits into from
Nov 3, 2022

Conversation

Sebastien-Ahkrin
Copy link
Contributor

Parts of #260

src/components/menu/MenuItems.tsx Outdated Show resolved Hide resolved
src/components/menu/MenuItems.tsx Outdated Show resolved Hide resolved
src/components/menu/MenuItems.tsx Outdated Show resolved Hide resolved
stories/components/menuitems.stories.tsx Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022

Codecov Report

Base: 92.40% // Head: 92.40% // No change to project coverage 👍

Coverage data is based on head (2f8f830) compared to base (102fd1a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #283   +/-   ##
=======================================
  Coverage   92.40%   92.40%           
=======================================
  Files          10       10           
  Lines         685      685           
  Branches      111      111           
=======================================
  Hits          633      633           
  Misses         52       52           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stropitek
Copy link
Contributor

image

The labels should be aligned vertically, like in this screenshot

@lpatiny
Copy link
Contributor

lpatiny commented Oct 28, 2022

@Sebastien-Ahkrin Sebastien-Ahkrin marked this pull request as draft October 28, 2022 20:20
@Sebastien-Ahkrin
Copy link
Contributor Author

When you open the drop down menu and then click somewhere else I would expect the menu closes: https://deploy-preview-283--analysis-ui-components.netlify.app/stories/?story=components--dropdownmenu--dropdown

Also the context menu seems to crash: https://deploy-preview-283--analysis-ui-components.netlify.app/stories/?story=components--dropdownmenu--context-dropdown

yeah sorry @lpatiny i'm still working on it, i mark the Pull request as draft sorry !

@lpatiny
Copy link
Contributor

lpatiny commented Oct 29, 2022

I'm eager that we replace in NMRium the current drop down by this new one that looks soo much better !!!

I have a specific case for which I would like a different icon color. Something like:

image

Does the current implementation allows this ?

This is related to cheminfo/nmrium#1841

@targos
Copy link
Member

targos commented Oct 29, 2022

Does the current implementation allows this ?

Yes, the icon can be any React element

@zakodium-oss zakodium-oss deleted a comment from netlify bot Nov 2, 2022
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 2, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c0c1937
Status: ✅  Deploy successful!
Preview URL: https://72cdab49.analysis-ui-components.pages.dev
Branch Preview URL: https://feat-dropdownmenu.analysis-ui-components.pages.dev

View logs

@Sebastien-Ahkrin Sebastien-Ahkrin marked this pull request as ready for review November 3, 2022 09:22
@targos targos merged commit 800a5a1 into main Nov 3, 2022
@targos targos deleted the feat-dropdownmenu branch November 3, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants