feat: add responsive chart option

[wadjih-bencheikh18]

closes : #249

[netlify]

✅ Deploy Preview for analysis-ui-components ready!

Name	Link
🔨 Latest commit	f40fad9
🔍 Latest deploy log	https://app.netlify.com/sites/analysis-ui-components/deploys/635bf5002dd4930008b14ac3
😎 Deploy Preview	https://deploy-preview-256--analysis-ui-components.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[wadjih-bencheikh18]

we need to solve zakodium-oss/react-d3-utils#26 in order to fix types error

[codecov-commenter]

Codecov Report

Base: 91.73% // Head: 91.73% // No change to project coverage 👍

Coverage data is based on head (40e307c) compared to base (c39abde).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #256   +/-   ##
=======================================
  Coverage   91.73%   91.73%           
=======================================
  Files           9        9           
  Lines         593      593           
  Branches      100      100           
=======================================
  Hits          544      544           
  Misses         49       49           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[lpatiny]

@wadjih-bencheikh18 is it expected to already work ? Because currently the spectrum do not take the full space yet

[wadjih-bencheikh18]

is it expected to already work ?

I didn't change the app I updated only the story

[stropitek]

There is an issue when resizing the window / split pane. Making the right pane bigger does not work.

@targos is it expected that when reducing the width of the window, the controlled side gets smaller? It seems counter intuitive to me.

[targos]

No, it is not expected.

[targos]

But I think it's a known issue, unrelated to this PR

[wadjih-bencheikh18]

But I think it's a known issue, unrelated to this PR

i will try to figure out why this is happening

[wadjih-bencheikh18]

The problem is with ResponsiveChart because this latter give to his child static width so we're in evil child splitpane case,

[lpatiny]

There is also the issue that the chart does not take the full height. It should not only take the full width but also the full height.

[targos]

The problem is with ResponsiveChart because this latter give to his child static width so we're in evil child splitpane case,

Yes exactly. I think I know how to fix it and will wait until this pr is merged.

[wadjih-bencheikh18]

Yes exactly.

There's also another bug in responsive chart when using percentage height

[targos]

It has a height of 0 for me:

[stropitek]

The tests are failing because the controls in MeasurementExplorer seem to be rendered outside of its container. This is why in the tests the button cannot be clicked (see in the screenshot how the control bar is almost invisible)

This can also be seen when looking at the story for MeasurementExplorer

[wadjih-bencheikh18]

the controls in MeasurementExplorer seem to be rendered outside of its container.

fixed, it was because of justify-content