Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to describe stream's chunk type more clearly #31

Closed
yutakahirano opened this issue Apr 6, 2015 · 2 comments
Closed

Need to describe stream's chunk type more clearly #31

yutakahirano opened this issue Apr 6, 2015 · 2 comments

Comments

@yutakahirano
Copy link
Owner

Asked by @wanderview at #25.

I think it would be better to define the Uint8Array chunk type where you define the stream concept for the object. Placing the chunk type down in ConsumeStream, etc makes it a bit hard to find.
Can you expand on what you means here?

@wanderview
Copy link

I mean change the text like this:

A Response object has an associated readable stream (initially an empty ReadableByteStream).

To something like:

A Response object has an associated readable stream (initially an empty ReadableByteStream). This stream must produce chunks of type Uint8Array.

@yutakahirano
Copy link
Owner Author

Fixed. fe6e740

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants