-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Timeout and elapsed time in same units #2826
Conversation
The elasped time is in micros-seconds and timeout is in milliseconds for endpoint /rpcz Set elasped time to milliseconds.
Can one of the admins verify this patch? |
Thx for your contribution @srivignessh ! |
Thanks indeed for the PR @srivignessh! I have added a few folks who can review this. |
Thanks, @kmuthukk, and @rkarthik007. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We ran this through our internal test suite and looks great.
cc @spolitov
Thanks for picking this up @srivignessh ! I'll merge this in now. Let me know if you'd like to pick up a different task, there's a handful of them that should be easy to get started with! We are working on broadening this list and keeping it relevant: https://github.com/YugaByte/yugabyte-db/issues?q=is%3Aopen+is%3Aissue+no%3Aassignee+label%3A%22help+wanted%22+label%3A%22good+first+issue%22 In the meantime:
|
The elasped time is in micros-seconds and
timeout is in milliseconds for endpoint /rpcz
Set elasped time to milliseconds.
Possible Fix to #2801