Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Timeout and elapsed time in same units #2826

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

srivignessh
Copy link
Contributor

The elasped time is in micros-seconds and
timeout is in milliseconds for endpoint /rpcz

Set elasped time to milliseconds.

Possible Fix to #2801

The elasped time is in micros-seconds and
timeout is in milliseconds for endpoint /rpcz

Set elasped time to milliseconds.
@yugabyte-ci
Copy link
Contributor

Can one of the admins verify this patch?

@kmuthukk
Copy link
Collaborator

kmuthukk commented Nov 3, 2019

Thx for your contribution @srivignessh !

@rkarthik007
Copy link
Collaborator

Thanks indeed for the PR @srivignessh! I have added a few folks who can review this.

@srivignessh
Copy link
Contributor Author

Thanks, @kmuthukk, and @rkarthik007.

Copy link
Contributor

@bmatican bmatican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We ran this through our internal test suite and looks great.
cc @spolitov

@bmatican
Copy link
Contributor

Thanks for picking this up @srivignessh ! I'll merge this in now.

Let me know if you'd like to pick up a different task, there's a handful of them that should be easy to get started with!

We are working on broadening this list and keeping it relevant: https://github.com/YugaByte/yugabyte-db/issues?q=is%3Aopen+is%3Aissue+no%3Aassignee+label%3A%22help+wanted%22+label%3A%22good+first+issue%22

In the meantime:

@bmatican bmatican merged commit 87962cc into yugabyte:master Nov 13, 2019
@srivignessh
Copy link
Contributor Author

srivignessh commented Nov 13, 2019

@bmatican Sure. I will take a look at them. I will start with #2877
Thanks for approving my changes and merging the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants