Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YSQL] TableLocks: Investigate missing object lock calls on statement/txn retries in extended query mode execution #24877

Open
1 task done
basavaraj29 opened this issue Nov 12, 2024 · 0 comments
Assignees
Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@basavaraj29
Copy link
Contributor

basavaraj29 commented Nov 12, 2024

Jira Link: DB-13996

Description

Once #24596 lands, enable TEST_enable_object_locking_for_table_locks, and run the following

./yb_build.sh --java-test TestPgTransparentRestarts#update
./yb_build.sh --java-test TestPgTransparentRestarts#testUpdateLong

both the tests fail, but when we change the tests to use withPreferQueryMode("simple"), they pass.

In the former mode, the object lock calls aren't being issued for the retries.

More details.
For transparent statement retries from ysql, we seem to receive the object lock requests for statements being retried only in simple query execution mode. In extended mode, the object lock requests aren't being made on statement retries. This would cause issues since the object locks could be tied to a transaction that would get aborted on statement retry, and the new transaction would proceed to taking row-level locks without acquiring the required object locks.

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@basavaraj29 basavaraj29 added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels Nov 12, 2024
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Nov 12, 2024
@yugabyte-ci yugabyte-ci removed the status/awaiting-triage Issue awaiting triage label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug priority/medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

2 participants