Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getwindowsversion().major doesn't work with Python 2.6 #400

Closed
Jamesc359 opened this issue Aug 18, 2012 · 0 comments
Closed

getwindowsversion().major doesn't work with Python 2.6 #400

Jamesc359 opened this issue Aug 18, 2012 · 0 comments

Comments

@Jamesc359
Copy link

Using named tuples needlessly breaks compatibility with versions of python <= 2.6

Changing line 313 from:
if sys.platform == 'win32' and sys.getwindowsversion().major >= 5:

To:
if sys.platform == 'win32' and sys.getwindowsversion()[0] >= 5:

fixes the issue.

youtube-dl --version
2012.02.27
python --version
Python 2.6.1
Windows Vista 64Bit

joedborg referenced this issue in joedborg/youtube-dl Nov 17, 2020
[pull] master from ytdl-org:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants