-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
National Geographic url not recognized / [generic] / Unsupported URL #22820
Comments
This looks identical to the scheme used on Disney's Go platform. I'm sure adding yet another brand to it is relatively trivial—I may give it a shot myself to see if it's doable, as I amateurishly fixed a related issue, but as I'm not actually putting a pull request in, who knows how long the fix will take to be put into an official release. Update: Yep, just as trivial as I expected, though looks as if the Adobe pass credentials break for me, but it should get you started. What I did:
|
I'm seeing this issue also. And they seem to do things differently from others covered by go.py, so if there is some kind of workaround I would really appreciate hearing about it, even if it involves a few steps. Unfortunately tmthywynn8's response isn't too helpful because I looked in go.py and while I could easily make the addition in his point 1, I'm mystified as to what he added and where he added it in his points 2 and 3. Maybe the go.py app has been changed significantly since his post but I could not for the life of me figure out how to do either of those things, otherwise I would have tested it and reported back. |
@tmthywynn8, I made your suggested changes, but I am still getting an error. I did make one change in your suggestion in regards to step number 2, I put 'nationalgeographic' instead of 'disneynow' so that it would get picked up correctly. Any help would be appreciated. Here is error I am getting now:
|
@tmthywynn8 are you able to assist? Anyone else able to provide suggestions on how to resolve this? |
Actually since my comment, thanks to this commit by @dstftw, the third step is no longer needed. Using this episode as the example though, looks like one needs to: Add two brands to the dictionary or whatever it's called in go.py. Between lines 40-41, paste the following:
Note: I don't know which of the two are actually needed now. Then, on the line reading (?P<sub_domain_2>, add |nationalgeographic to it. There's an issue with retrieving the video ID in the code, but I haven't looked at the logic for that yet. Assume it's because they once again changed the layout to something like: "videoIdCode":"vdka15374108" which probably hasn't been accounted for. |
@tmthywynn8 have you found anything about the layout? I would be interested in finding out more about the layout and how to troubleshoot this if you want to contact me you can find my email address on my profile. Thank you for your assistance in this. I look forward to hearing from you. |
@tmthywynn8 do you have any suggestions? |
any progress? |
@tmthywynn8 would you be able to look at the layout again and see how this could be resolved? |
Whoops, wrong issue. My apologies for the false hope. No, haven't had the time. While adding in national Geographic to the dictionary and accounting for the www addition in the regular expression, there are still issues with obtaining metadata information, probably because (1) it has its own legacy information for doing so, or because (2) there are different logic paths being taken if it's ABC or Freeform vs. everything else, and it's going for the latter which probably won't work—haven't looked into the way NG presents its information. I'm not a developer—just somewhat decent at regexp, so would need to conceptualize the logic in go.py first before adapting it for NG (if necessary). |
I managed to get this working with the following patch: Add the following brand to the
And replace the following line:
With:
|
JamKage any possibility this might work for FX? Please see #23754 which might be a very similar issue. |
@JamKage, any progress on the National Geographic #26785? It's still not able to be downloaded by YouTube-dl; as it was flagged to have "conflicts that must be resolved" before it is the "PR is merged" as well. Your assistance on it will be very much appreciated, just as the Fxnetworks that is now running fine. Thanks. |
Can someone take a look at this? National Geographic is still not working after all this time. |
I wish I could help with this. NatGeo support would be a great feature |
Checklist
Verbose log
Description
My understanding is National Geographic is supported. This was reported in January, but it was immediately closed as "Duplicate" and I cannot find what it's a duplicate of. It appears to be the same issue. I was therefor unable to find if there is any kind of workaround.
The text was updated successfully, but these errors were encountered: