fix(uploader): fix chooseImage error in PC #5477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landluck
reviewed
Jul 10, 2023
packages/uploader/utils.ts
Outdated
| @@ -1,6 +1,15 @@ | |||
| import { pickExclude } from '../common/utils'; | |||
| import { isImageUrl, isVideoUrl } from '../common/validator'; | |||
|
|
|||
| let isRunningOnPC = false; | |||
|
|
|||
| try { | |||
There was a problem hiding this comment.
全局有一个 getSystemInfoSync 的工具函数，可以直接用，不用自己在写一个了
There was a problem hiding this comment.
isRunningOnPC 简化一下，就叫 isPC 吧，在 utils 里面写个工具函数
landluck
reviewed
Jul 10, 2023
packages/common/utils.ts
Outdated
| @@ -109,3 +113,8 @@ export function getCurrentPage<T>() { | |||
| const pages = getCurrentPages(); | |||
| return pages[pages.length - 1] as T & WechatMiniprogram.Page.TrivialInstance; | |||
| } | |||
|
|
|||
| export function isPC() { | |||
There was a problem hiding this comment.
可以作为一个场景的，例如 export const isPc = xxx ，没必须要每次使用都重新计算
landluck
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5438