From b403700d412b06d6a401672450244a578b4d7aba Mon Sep 17 00:00:00 2001 From: Oscar Vestlie Date: Tue, 9 Jul 2024 13:22:14 -0700 Subject: [PATCH] Filter test on windows instead of marking flaky (#3770) PosixDirectoryGetNextTest.SunnyDayStaticContent b/302730696 --- .../nplb/posix_compliance/posix_directory_get_next_test.cc | 2 +- starboard/win/win32/test_filters.py | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/starboard/nplb/posix_compliance/posix_directory_get_next_test.cc b/starboard/nplb/posix_compliance/posix_directory_get_next_test.cc index 08284ec4b5f7..57a437f6b0e5 100644 --- a/starboard/nplb/posix_compliance/posix_directory_get_next_test.cc +++ b/starboard/nplb/posix_compliance/posix_directory_get_next_test.cc @@ -96,7 +96,7 @@ TEST(PosixDirectoryGetNextTest, SunnyDay) { EXPECT_TRUE(closedir(directory) == 0); } -TEST(PosixDirectoryGetNextTest, FLAKY_SunnyDayStaticContent) { +TEST(PosixDirectoryGetNextTest, SunnyDayStaticContent) { std::string testdata_dir = GetFileTestsDataDir(); EXPECT_FALSE(testdata_dir.empty()); EXPECT_TRUE(FileExists(testdata_dir.c_str())) diff --git a/starboard/win/win32/test_filters.py b/starboard/win/win32/test_filters.py index 735ef62543be..4e42e1ed50ea 100644 --- a/starboard/win/win32/test_filters.py +++ b/starboard/win/win32/test_filters.py @@ -62,6 +62,9 @@ # TODO: b/349109647 Disable flaky test. 'SbPlayerGetMediaTimeTests/*', + + # Known flaky on windows. + 'PosixDirectoryGetNextTest.SunnyDayStaticContent', ], 'player_filter_tests': [ # These tests fail on our VMs for win-win32 builds due to missing