Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Support for bluetooth headphones #24

Closed
Wjxfi opened this issue Feb 24, 2023 · 10 comments
Closed

Support for bluetooth headphones #24

Wjxfi opened this issue Feb 24, 2023 · 10 comments

Comments

@Wjxfi
Copy link

Wjxfi commented Feb 24, 2023

it records on a regular microphone in the phone

miui 13.0.5, android 12

@Bnyro
Copy link
Member

Bnyro commented Feb 24, 2023

This would require to add android.permission.MODIFY_AUDIO_SETTINGS to the app, I don't think it would be worth adding tbh.
@matchboxbananasynergy, opinion?

@Tobias-Lauerbach
Copy link
Contributor

Tobias-Lauerbach commented Feb 24, 2023

I thought about opening a feature request, for a similar feature.

Feature:

I wanted to ask for the ability to change or see which audio source/device is used (for example: wired headphones / Bluetooth / build in mic).

Use case:

This would be useful if you want to make sure that the quality of the recording is good (for example as Backup audio for video recordings or just to select your build in mic if your headphones mic sucks)

(If needed, I would be happy to open this in a separate issue. Should I? @Bnyro )

@Wjxfi
Copy link
Author

Wjxfi commented Feb 24, 2023

why not? Without bluetooth I (me) and many other people absolutely do not need your app.
my expensive headphones should work.

@matchboxbananasynergy
Copy link

This would require to add android.permission.MODIFY_AUDIO_SETTINGS to the app, I don't think it would be worth adding tbh. @matchboxbananasynergy, opinion?

At first glance and after getting a second opinion, that permission generally looks fine. I wonder if it's the "proper" way to do it, though. Perhaps it might make sense to look at some other notable/high quality projects to see how they implement this and which permission they use?

@Wjxfi
Copy link
Author

Wjxfi commented Feb 24, 2023

mixplorer allows you to open any .apk file as code. You can use it to view the code of ordinary applications (not open-source)

To get the apk file you can use any app backup application

so you can get more information from other applications about the problem.

You can download the mixplorer app below (Official source)
https://forum.xda-developers.com/showpost.php?p=23109280&postcount=2

@akano12
Copy link

akano12 commented Feb 24, 2023

mixplorer allows you to open any .apk file as code. You can use it to view the code of ordinary applications (not open-source)

To get the apk file you can use any app backup application

so you can get more information from other applications about the problem.

You can download the free mixplorer app below (it's actually paid, but they posted it here). https://t.me/mixplorer_channel

1- MiXplorer is free, it was never paid. (I do suggest you get it from original source instead of this channel)
2- You can't view the source of applications with any file manager, you'll have to de-obfuscate classes, fields, and methods which take a lot of time and patience.
3- Devs never said they don't know how to do what you asked for...... 😉

@Wjxfi
Copy link
Author

Wjxfi commented Feb 24, 2023

1- MiXplorer is free, it was never paid. (I do suggest you get it from original source instead of this channel)

I just checked it out, it's paid on the play market.

2- You can't view the source of applications with any file manager, you'll have to de-obfuscate classes, fields, and methods which take a lot of time and patience.

I just did it through mixplorer, what are you talking about? (at this point I did it again)

3- Devs never said they don't know how to do what you asked for...... 😉

a lot of people don't know that (such as you).


it's so funny. Probably wanted to seem smart...

edit:
I changed the link to the official source.

@Bnyro Bnyro changed the title (bug) does not work with bluetooth headphones Support for bluetooth headphones Feb 25, 2023
@Bnyro
Copy link
Member

Bnyro commented Feb 25, 2023

Adding support for bluetooth headphones was never the issue.
The issue is the permission that would need to be added in order for it to work.
And no, even if I didn't know how it works, I wouldn't reverse engineer a closed source app for it.

@Wjxfi
Copy link
Author

Wjxfi commented Feb 25, 2023

Your friend agreed to this permission

I really hope you do support for this

@matchboxbananasynergy
Copy link

What I "agree" to, doesn't matter. I'm not the app's developer. Also, while I did say that the permission required for this should technically be fine, I'm not certain whether it is the optimal way to achieve this. Please give the actual developer of the app some room to breathe and think about whether this is something they want to spend a substantial amount of effort in implementing.

@Bnyro Bnyro closed this as completed in 3314e5e Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants