Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In dockerMonitoring.writeToFile(), replace list of metrics with JSON file. #3

Open
fokaefs opened this issue May 13, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@fokaefs
Copy link

fokaefs commented May 13, 2022

In order to make the method more generic and independent of predefined lists of metrics, I recommend to replace the long parameter list with a JSON file (the same that is saved in the database). Writing to a file, like writing to a database should be independent of the monitor (Docker or otherwise).

  • [ Replace parameter list with JSON file]
  • [ Add checks for missing metrics or empty file]
  • [ Add warnings in a log for missing metrics or empty file. Do not interrupt the execution of the monitor. Do not use log4j for the logging part ]
@fokaefs fokaefs added the enhancement New feature or request label May 13, 2022
@fokaefs
Copy link
Author

fokaefs commented May 13, 2022

A configuration file to specify the expected format of the JSON file may be necessary.

@wejdeneHaouari
Copy link
Collaborator

the JSON file should be an input from the user, or it's the a JSON variable similar to write_db function ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants