Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling Duplicate Changes in PushPull Logic #1001

Open
kokodak opened this issue Sep 7, 2024 · 0 comments
Open

Handling Duplicate Changes in PushPull Logic #1001

kokodak opened this issue Sep 7, 2024 · 0 comments
Assignees
Labels
bug 🐞 Something isn't working

Comments

@kokodak
Copy link
Member

kokodak commented Sep 7, 2024

What happened:

image

In the scenario depicted in the provided image, there are instances where duplicate changes are not being filtered correctly.
This leads to a violation of idempotency for duplicate operations, resulting in unintended consequences.

When attempting to reproduce this issue locally, it can be observed as follows:

Screen.Recording.2024-09-05.at.11.25.41.PM.mov

The main cause of this issue is that when the PushPull logic partially fails, it is in an environment where atomicity is not ensured.

To solve this problem, we need to consider additional validation methods beyond ClientSeq to validate whether the change already exists.

What you expected to happen:
The system should effectively filter out duplicate changes to maintain idempotency and prevent unintended results.

How to reproduce it (as minimally and precisely as possible):

  1. Request PushPull API
  2. Failed to reflect ClientInfo in the database
  3. Client didn't receive an error response
  4. Re-request PushPull API

Anything else we need to know?:
Related to #805

Environment:

  • Operating system:
  • Browser and version:
  • Yorkie version (use yorkie version): 0.5.0
  • Yorkie JS SDK version:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

2 participants