Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Client.UpdateMetadata API in the JS SDK #221

Closed
hackerwins opened this issue Aug 6, 2021 · 2 comments
Closed

Implement Client.UpdateMetadata API in the JS SDK #221

hackerwins opened this issue Aug 6, 2021 · 2 comments
Assignees
@hackerwins
Labels
enhancement 🌟 New feature or request

Comments

@hackerwins
Copy link
Member

Description:

We recently added an API to update the client's metadata: yorkie-team/yorkie#153

Let's implement this API in the JS SDK.

Why:

  • Implementing this API in the JS SDK would be good to check whether it is actually usable.
@hackerwins hackerwins added enhancement 🌟 New feature or request good first issue 🐤 Good for newcomers and removed good first issue 🐤 Good for newcomers labels Aug 6, 2021
@hackerwins hackerwins self-assigned this Aug 8, 2021
@hackerwins hackerwins removed their assignment Aug 15, 2021
@xoxwgys56
Copy link
Contributor

@hackerwins

Looks like already implemented on this line.
If not, could you add extra explanation?

@hackerwins hackerwins self-assigned this Sep 25, 2021
@hackerwins
Copy link
Member Author

@xoxwgys56 Thanks for the comment. This issue is addressed by #236. The link is missing from the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hackerwins hackerwins

Labels
enhancement 🌟 New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hackerwins @xoxwgys56