Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch median operator #11

Open
mmarkell opened this issue Sep 21, 2024 · 0 comments
Open

patch median operator #11

mmarkell opened this issue Sep 21, 2024 · 0 comments

Comments

@mmarkell
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch loess@1.3.5 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/loess/dist/index.js b/node_modules/loess/dist/index.js
index 9ce0887..8b0bedb 100644
--- a/node_modules/loess/dist/index.js
+++ b/node_modules/loess/dist/index.js
@@ -86,7 +86,9 @@ var Loess = function () {
           fitted.push(_mathjs2.default.squeeze(_mathjs2.default.multiply(point, fit.beta)));
           residuals.push(fit.residual);
           betas.push(fit.beta.toArray());
-          var median = _mathjs2.default.median(_mathjs2.default.abs(fit.residual));
+          const data = _mathjs2.default.abs(fit.residual);
+          // if it's NaN, replace it with 0
+          const median = _mathjs2.default.median(data.map((d) => isNaN(d) ? 0 : d));
           wt[idx] = fit.residual.map(function (r) {
             return (0, _helpers.weightFunc)(r, 6 * median, 2);
           });

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant