-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Storybook in the project #26
Comments
@yonatanmgr What do you think? |
That's a good idea, though I do have a question - does it require us to copy all of our components manually to Storybook? |
Yes. We need to create |
I would put there only the common reusable components. In addition, we can put all the stories in one file, although it's a best practice to separate to file for each component. |
Sounds good! How do we start with this? If any of you wants this I'll assign you, if not I'll do it! |
@yonatanmgr I can do it. |
@zivnadel Assigning you! |
According to the developers of Storybook, electron is not supported, and there are no plans to add support in the future as stated in storybookjs/storybook#1435. Although I was able to successfully initialize Storybook in the project, I'm concerned that it may not work seamlessly with electron's core. Therefore, I have decided to not proceed with it. |
I suggest we add Storybook to the project. Storybook is a user interface development environment that allows us to build, test, and showcase our UI components in an isolated, reusable environment.
It will significantly improve collaboration, and will help keeping unified design language across the entire app.
I started testing it locally, and so far, it seems suitable for this project.
The text was updated successfully, but these errors were encountered: