Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to not link Carthage framework? #426

Closed
sbarow opened this issue Oct 29, 2018 · 4 comments
Closed

Ability to not link Carthage framework? #426

sbarow opened this issue Oct 29, 2018 · 4 comments

Comments

@sbarow
Copy link
Contributor

sbarow commented Oct 29, 2018

In a framework with the following:

dependencies:
	- carthage: Firebase.framework
	  link: false

Firebase would still be linked in Link Binary With Libraries in the Build Phases, is this expected or is there another way to achieve this?

Thanks.

@yonaskolb
Copy link
Owner

Yeah looks like that link property is not being used for carthage dependencies. What's the use case of adding a carthage dependency but not linking it?

@sbarow
Copy link
Contributor Author

sbarow commented Nov 2, 2018

From firebase/firebase-ios-sdk#911

The Firebase.framework is only needed to provide build time access to the Firebase module and Firebase.h. It is not needed for linking. Thus a workaround is to delete Firebase.framework from the Link Binary With Libraries Build Phase.

Don't think its a very common use case but does solve this issue for now.

@yonaskolb
Copy link
Owner

Added here #432

@sbarow
Copy link
Contributor Author

sbarow commented Nov 2, 2018

Wow that was quick, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants