Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin: add baseConfig option #245

Merged
merged 5 commits into from
Aug 10, 2022
Merged

admin: add baseConfig option #245

merged 5 commits into from
Aug 10, 2022

Conversation

yottahmd
Copy link
Collaborator

@yottahmd yottahmd commented Aug 10, 2022

This PR is related to #216

@yottahmd yottahmd marked this pull request as ready for review August 10, 2022 04:19
@dagu-org dagu-org deleted a comment from codecov-commenter Aug 10, 2022
@dagu-org dagu-org deleted a comment from codecov-commenter Aug 10, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #245 (ff88a2a) into main (dac81b6) will increase coverage by 0.41%.
The diff coverage is 96.22%.

@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
+ Coverage   86.31%   86.73%   +0.41%     
==========================================
  Files          46       46              
  Lines        3282     3287       +5     
==========================================
+ Hits         2833     2851      +18     
+ Misses        322      311      -11     
+ Partials      127      125       -2     
Impacted Files Coverage Δ
internal/admin/loader.go 95.52% <93.33%> (+12.18%) ⬆️
cmd/dagu.go 75.00% <100.00%> (+2.08%) ⬆️
cmd/dry.go 77.77% <100.00%> (-2.87%) ⬇️
cmd/retry.go 86.04% <100.00%> (-0.92%) ⬇️
cmd/start.go 79.31% <100.00%> (-1.94%) ⬇️
cmd/status.go 70.00% <100.00%> (-5.00%) ⬇️
cmd/stop.go 78.57% <100.00%> (-4.77%) ⬇️
internal/admin/config.go 85.21% <100.00%> (+0.95%) ⬆️
internal/config/loader.go 83.67% <100.00%> (-2.14%) ⬇️
internal/controller/controller.go 75.97% <100.00%> (-0.27%) ⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@yottahmd yottahmd merged commit 4b68a51 into main Aug 10, 2022
@yottahmd yottahmd added this to the v1.7.0 milestone Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants