Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Support newline delimited JSON (ndjons/jsonl) #14

Closed
corneliusroemer opened this issue Mar 21, 2024 · 7 comments · Fixed by #28
Closed

ENH: Support newline delimited JSON (ndjons/jsonl) #14

corneliusroemer opened this issue Mar 21, 2024 · 7 comments · Fixed by #28
Labels
feature request New feature or request v0.2.0

Comments

@corneliusroemer
Copy link
Contributor

corneliusroemer commented Mar 21, 2024

I'd love to use jnv with newline delimited json files as well. Right now, when I load an ndjson file, I get the following error:

$ jnv ncbi_dataset/data/data_report.jsonl 
Error: trailing characters at line 2 column 1

jq on the other hand has absolutely no issue with jsonl files.

@edgarrmondragon
Copy link

A JSON lines file was the first file I tried to used jnv with 😅. Big +1 for this one.

@ynqa ynqa added the feature request New feature or request label Mar 23, 2024
@ynqa
Copy link
Owner

ynqa commented Mar 23, 2024

Thanks! But it seems to be a duplicate of #9, so I will close it 🙏

@ynqa ynqa closed this as completed Mar 23, 2024
@corneliusroemer
Copy link
Contributor Author

Hard to find the original as I've never heard of Json stream being used to talk about Jsonl/ndjson.

Could you edit the title of the original to be clearer?

Also maybe close as "duplicate" not as "completed", when I saw the purple completion I was already happy that it was added only to be disappointed that it was closed as duplicate 😇

@ynqa
Copy link
Owner

ynqa commented Mar 24, 2024

@corneliusroemer

Could you edit the title of the original to be clearer?

Sure. But let me confirm what both issues want to say.

These are adding the functionality that allows filtering over multiple JSON structures contained in a single file/stdin, right?

Also maybe close as "duplicate" not as "completed", when I saw the purple completion I was already happy that it was added only to be disappointed that it was closed as duplicate 😇

I apologize for changing the issue state on my own. I'll proceed in a way that everyone can agree on. Therefore, please let me reopen it (Even if it is deemed a duplicate again and gets closed) 🙇

@ynqa
Copy link
Owner

ynqa commented Mar 24, 2024

@corneliusroemer In #28, I've made it possible to handle multiple JSONs. Please check whether the problem addressed in this issue has been resolved.

@ynqa ynqa added the v0.2.0 label Mar 25, 2024
@ynqa ynqa closed this as completed in #28 Mar 25, 2024
@ynqa
Copy link
Owner

ynqa commented Mar 25, 2024

@corneliusroemer Released v0.2.0 which addressed this issue. Please check it out 🎉

@Lewenhaupt
Copy link

Installed this last week and didn't get to test it until today when I had a use-case I really needed it for. Encountered the trailing issue, found this issue, updated, and now it works! @ynqa thanks for a great tool :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request v0.2.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants