Tune ruff config and fix existing code

Author: ymyzk

pyproject.toml

@@ -24,5 +24,58 @@ markers = [
     "integration: mark as an integration test.",
 ]
 
+[tool.ruff]
+target-version = "py37"
+
+[tool.ruff.lint]
+select = [
+    # pycodestyle
+    "E",
+    "W",
+    # Pyflakes
+    "F",
+    # pydocstyle
+    "D",
+    # isort
+    "I",
+    # pyupgrade
+    "UP",
+    # flake8-annotations
+    "ANN",
+    # flake8-bandit
+    "S",
+    # flake8-bugbear
+    "B",
+    # flake8-implicit-str-concat
+    "ISC",
+    # flake8-logging
+    "LOG",
+    # flake8-logging-format
+    "G",
+    # flake8-simplify
+    "SIM",
+    # Ruff-specific rules
+    "RUF",
+]
+ignore = [
+    "D100",
+    "D101",
+    "D102",
+    "D103",
+    "D104",
+    "D400",
+    "D401",
+    "D415",
+]
+
+[tool.ruff.lint.isort]
+force-sort-within-sections = true
+
+[tool.ruff.lint.per-file-ignores]
+"tests/*" = [
+    # flake8-bandit: assert
+    "S101",
+]
+
 [tool.setuptools_scm]
 write_to = "src/tox_gh_actions/version.py"

src/tox_gh_actions/plugin.py

@@ -1,5 +1,4 @@
 from itertools import product
-
 from logging import getLogger
 import os
 import sys
@@ -42,7 +41,7 @@ def tox_add_core_config(core_conf: ConfigSet, state: State) -> None:
     logger.debug("original envlist: %s", original_envlist.envs)
 
     versions = get_python_version_keys()
-    logger.debug("Python versions: {}".format(versions))
+    logger.debug("Python versions: %s", versions)
 
     gh_actions_config = load_config(config)
     logger.debug("tox-gh-actions config: %s", gh_actions_config)
@@ -166,6 +165,7 @@ def get_python_version_keys() -> List[str]:
     - CPython 3.8.z => [3.8, 3]
     - PyPy 3.6 (v7.3.z) => [pypy-3.6, pypy-3, pypy3]
     - Pyston based on Python CPython 3.8.8 (v2.2) => [pyston-3.8, pyston-3]
+
     """
     major_version = str(sys.version_info[0])
     major_minor_version = ".".join([str(i) for i in sys.version_info[:2]])
@@ -226,11 +226,9 @@ def is_log_grouping_enabled(options: Parsed) -> bool:
 
 def is_env_specified(config: Config) -> bool:
     """Returns True when environments are explicitly given"""
-    if hasattr(config.options, "env") and not config.options.env.is_default_list:
-        # is_default_list becomes False when TOXENV is a non-empty string
-        # and when command line argument (-e) is given.
-        return True
-    return False
+    # is_default_list becomes False when TOXENV is a non-empty string
+    # and when command line argument (-e) is given.
+    return hasattr(config.options, "env") and not config.options.env.is_default_list
 
 
 def parse_factors_dict(value: str) -> Dict[str, List[str]]:
@@ -256,6 +254,7 @@ def parse_factors_dict(value: str) -> Dict[str, List[str]]:
 
 def parse_dict(value: str) -> Dict[str, str]:
     """Parse a dict value from the tox config.
+
     .. code-block: ini
         [travis]
         python =

tests/test_integration.py

@@ -4,7 +4,6 @@
 from pytest import MonkeyPatch
 from tox.pytest import ToxProjectCreator, init_fixture  # noqa: F401
 
-
 requires_cpython = pytest.mark.skipif(
     sys.implementation.name != "cpython", reason="Requires CPython to run this test"
 )