feat: Insert newlines at the beginning and end of the stringified jso…

…n when a space option is not 0
ymmooot · May 13, 2019 · 337f5f9 · 337f5f9
1 parent 5c00b64
commit 337f5f9
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -22,6 +22,11 @@ import Vue from 'vue';
 import NuxtJsonld from 'nuxt-jsonld';
 
 Vue.use(NuxtJsonld);
+
+// you can set the indentation
+Vue.use(NuxtJsonld, {
+  space: 4, // default: 2
+});
 ```
 
 ## Usage

diff --git a/example/plugins/jsonld.js b/example/plugins/jsonld.js
@@ -1,4 +1,6 @@
 import Vue from 'vue';
 import NuxtJsonld from 'nuxt-jsonld';
 
-Vue.use(NuxtJsonld);
+Vue.use(NuxtJsonld, {
+  space: 4, // default: 2
+});
diff --git a/src/createMixin.js b/src/createMixin.js
@@ -1,7 +1,7 @@
-module.exports = options => {
+module.exports = (options = {}) => {
   const mergedOptions = {
     space: 2,
-    ...(options || {}),
+    ...options,
   };
 
   return {
@@ -10,13 +10,16 @@ module.exports = options => {
         return {};
       }
 
+      const stringifiedJson = JSON.stringify(this.$options.jsonld.call(this), null, mergedOptions.space);
+      const innerHTML = mergedOptions.space === 0 ? stringifiedJson : `\n${stringifiedJson}\n`;
+
       const hid = `nuxt-jsonld-${this._uid}`;
       return {
         script: [
           {
             hid,
             type: 'application/ld+json',
-            innerHTML: JSON.stringify(this.$options.jsonld.call(this), null, mergedOptions.space),
+            innerHTML,
           },
         ],
         __dangerouslyDisableSanitizersByTagID: {

diff --git a/test/createMixin.spec.js b/test/createMixin.spec.js
@@ -63,7 +63,8 @@ describe('with jsonld', () => {
       script: [
         {
           hid: mockHid,
-          innerHTML: `{
+          innerHTML: `
+{
   "@context": "http://schema.org",
   "@type": "BreadcrumbList",
   "itemListElement": [
@@ -82,7 +83,8 @@ describe('with jsonld', () => {
       }
     }
   ]
-}`,
+}
+`,
           type: 'application/ld+json',
         },
       ],
@@ -101,7 +103,8 @@ describe('with jsonld', () => {
         script: [
           {
             hid: mockHid,
-            innerHTML: `{
+            innerHTML: `
+{
 	"@context": "http://schema.org",
 	"@type": "BreadcrumbList",
 	"itemListElement": [
@@ -120,7 +123,8 @@ describe('with jsonld', () => {
 			}
 		}
 	]
-}`,
+}
+`,
             type: 'application/ld+json',
           },
         ],