Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve "Compiling from the .sass files" #81

Open
machour opened this issue Dec 30, 2018 · 1 comment
Open

[docs] Improve "Compiling from the .sass files" #81

machour opened this issue Dec 30, 2018 · 1 comment
Labels
status:ready for adoption Feel free to implement this issue. type:docs Documentation

Comments

@machour
Copy link
Member

machour commented Dec 30, 2018

https://github.com/yiisoft/yii2-bootstrap4/blob/master/docs/guide/assets-setup.md#compiling-from-the-sass-files

Here we're implying that in order to be able to modify bootstrap CSS, we should not install bootstrap from npm, and that we should maintain it manually instead.

The statement is obviously wrong, and I think that we might want to recommend a more modern approach, like using bootstrap from npm and properly customizing its variable in your site.scss file:

// Customize any bootstrap variable before including the main file from npm
// @see https://github.com/twbs/bootstrap/blob/v4.1.2/scss/_variables.scss

$primary: "#ffcc00"; 
@import "~node_modules/bootstrap/dist/bootstrap.scss"

.customer-area {
   // your own CSS
}

Would that be okay ?

@samdark samdark added the type:docs Documentation label Dec 30, 2018
@samdark
Copy link
Member

samdark commented Dec 30, 2018

Yes.

@samdark samdark added the status:ready for adoption Feel free to implement this issue. label Dec 30, 2018
@samdark samdark added this to the 1.0.0 milestone Jan 15, 2019
@samdark samdark modified the milestones: 1.0.0, 1.0.1 Jan 28, 2019
@samdark samdark removed this from the 2.0.1 milestone Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready for adoption Feel free to implement this issue. type:docs Documentation
Projects
None yet
Development

No branches or pull requests

2 participants