Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

[enhancement] rake task generated migration does not recognise primary key type #23

Open
swiknaba opened this issue Dec 15, 2018 · 1 comment

Comments

@swiknaba
Copy link

Problem:
The migration generated from bundle exec rails generate approval:install does not recognize the type of the primary id being used, thus one has to manually adjust the migration file if a non-integer type, e.g. uuid is used. Affected columns are:

  • approval_comments.user_id
  • approval_items.resource_id
  • approval_requests.request_user_id
  • approval_requests.respond_user_id

Suggestion:
Let bundle exec rails generate approval:install accept an argument to set the type of the primary key type (defaults to integer if omitted for convenience).

@yhirano55
Copy link
Owner

Thanks for your opening this issue. I think it's good catch. Please open the pull request if you can.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants