Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaped underscores within Korean emoji shorthand have broken #203

Closed
yhatt opened this issue Oct 8, 2020 · 0 comments · Fixed by #206
Closed

Escaped underscores within Korean emoji shorthand have broken #203

yhatt opened this issue Oct 8, 2020 · 0 comments · Fixed by #206
Labels
bug Something isn't working

Comments

@yhatt
Copy link
Owner

yhatt commented Oct 8, 2020

Slack is now available in Korean and Slack users can use Hangul as the name of custom emoji and emoji alias. Well, the Korean emoji shorthand brings #98 again:

<Blocks>
  <Section>
	<p><Escape>_:white_check_mark:_</Escape></p>
	<p><Escape>_:체크표시_초록:_</Escape></p>
  </Section>
</Blocks>

It appears that the escaped underscore inside emoji shorthand also has broken rendering.

We have to fix and recover emoji rendering by preventing escape for underscore within Korean emoji shorthand. Additional Unicode blocks Slack accepts as emoji shorthand are following:

  • Hangul Jamo (U+1100 - U+11FF)
  • Hangul Compatibility Jamo (U+3130 - U+318F)
  • Hangul Jamo Extended-A (U+A960 - U+A97F)
  • Hangul Syllables (U+AC00 - U+D7AF)
  • Hangul Jamo Extended-B (U+D7B0 - U+D7FF)
@yhatt yhatt added the bug Something isn't working label Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant