From 35e4e8c6ea39c2d6bb9a2b0dea8b5a0fcbdc8159 Mon Sep 17 00:00:00 2001 From: EmilyZhang777 <48967088+EmilyZhang777@users.noreply.github.com> Date: Fri, 12 Apr 2024 10:10:54 -0500 Subject: [PATCH 1/4] Update CODEOWNERS (#36) --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 8acf77e..ba445ca 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1 +1 @@ -* @yext/slapshot +* @yext/watson From 2a853e9198421521418bde738c61734a8a661461 Mon Sep 17 00:00:00 2001 From: Jesuye David Date: Mon, 15 Apr 2024 12:19:08 -0400 Subject: [PATCH 2/4] udpated coverage workflow for node20 --- .github/workflows/coverage.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 708a39d..854b451 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -29,11 +29,11 @@ jobs: outputs: coverage-percent: ${{ steps.parse-coverage.outputs.coverage-percent }} steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: ref: ${{ inputs.comparison_branch }} - name: Use Node.js 16.x - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: 16.x registry-url: 'https://registry.npmjs.org' @@ -52,9 +52,9 @@ jobs: outputs: coverage-percent: ${{ steps.parse-coverage.outputs.coverage-percent }} steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Use Node.js 16.x - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: 16.x registry-url: 'https://registry.npmjs.org' @@ -69,7 +69,7 @@ jobs: id: parse-coverage - run: echo current coverage is ${{ steps.parse-coverage.outputs.coverage-percent }}% - name: Upload lcov build artifact - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: coverage path: coverage/ @@ -78,7 +78,7 @@ jobs: runs-on: ubuntu-latest needs: [base-coverage, current-coverage] steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Check if percent is too low run: | percentIsTooLow=$(echo ${{ needs.base-coverage.outputs.coverage-percent }} ${{ needs.current-coverage.outputs.coverage-percent }} | @@ -89,11 +89,11 @@ jobs: exit 1 fi - name: Download the current coverage - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: coverage path: coverage/ - name: Coveralls - uses: coverallsapp/github-action@master + uses: coverallsapp/github-action@v2 with: github-token: ${{ secrets.caller_github_token }} From c4dd37305687920223dbd6025a9c18e7a7bced24 Mon Sep 17 00:00:00 2001 From: nmanu1 <88398086+nmanu1@users.noreply.github.com> Date: Mon, 15 Apr 2024 16:45:49 -0400 Subject: [PATCH 3/4] Remove node 16 deprecation warnings from most workflows (#38) Update `main.yml`, `percy_snapshots.yml`, `run-linting.yml`, `run_tests.yml`, `sync_default_branch.yml`, `sync_develop_and_main.yml`, `third_party_notices_check.yml`, `.update_docs.yml`, `version_update.yml`, and `wcag_test.yml` to remove Node 16 deprecation warnings. J=WAT-3814 TEST=manual For `main.yml`, test the check on this PR, for `percy_snapshots.yml`, test in `answers-search-ui`, and for the other workflows, test in a fork of `search-ui-react` and see that the workflows no longer produce warnings. --- .github/workflows/main.yml | 2 +- .github/workflows/percy_snapshots.yml | 4 ++-- .github/workflows/run-linting.yml | 4 ++-- .github/workflows/run_tests.yml | 4 ++-- .github/workflows/sync_default_branch.yml | 2 +- .github/workflows/sync_develop_and_main.yml | 4 ++-- .github/workflows/third_party_notices_check.yml | 4 ++-- .github/workflows/update_docs.yml | 4 ++-- .github/workflows/version_update.yml | 4 ++-- .github/workflows/wcag_test.yml | 4 ++-- 10 files changed, 18 insertions(+), 18 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index c81bab7..5beb776 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -21,5 +21,5 @@ jobs: image: returntocorp/semgrep if: (github.actor != 'dependabot[bot]') steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - run: semgrep ci diff --git a/.github/workflows/percy_snapshots.yml b/.github/workflows/percy_snapshots.yml index 5eddfe9..1750d0d 100644 --- a/.github/workflows/percy_snapshots.yml +++ b/.github/workflows/percy_snapshots.yml @@ -33,11 +33,11 @@ jobs: percy_snapshots: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: fetch-depth: ${{ inputs.fetch_depth }} - name: Use Node.js 16.x - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: 16.x - run: npm ci diff --git a/.github/workflows/run-linting.yml b/.github/workflows/run-linting.yml index 112d594..b58300a 100644 --- a/.github/workflows/run-linting.yml +++ b/.github/workflows/run-linting.yml @@ -13,8 +13,8 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Use Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 - run: npm ci - run: ${{ inputs.lint_script }} \ No newline at end of file diff --git a/.github/workflows/run_tests.yml b/.github/workflows/run_tests.yml index bfb23f5..f53bd5e 100644 --- a/.github/workflows/run_tests.yml +++ b/.github/workflows/run_tests.yml @@ -40,9 +40,9 @@ jobs: node-version: ${{ fromJSON(inputs.node_matrix) }} steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} registry-url: 'https://registry.npmjs.org' diff --git a/.github/workflows/sync_default_branch.yml b/.github/workflows/sync_default_branch.yml index 12d38c0..331f01a 100644 --- a/.github/workflows/sync_default_branch.yml +++ b/.github/workflows/sync_default_branch.yml @@ -16,7 +16,7 @@ jobs: name: Sync branches steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Sync ${{ github.event.repository.default_branch }} with ${{ inputs.target_branch }} uses: devmasx/merge-branch@v1.4.0 with: diff --git a/.github/workflows/sync_develop_and_main.yml b/.github/workflows/sync_develop_and_main.yml index a33a1bd..061aac8 100644 --- a/.github/workflows/sync_develop_and_main.yml +++ b/.github/workflows/sync_develop_and_main.yml @@ -14,7 +14,7 @@ jobs: create_pull_request: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Extract version and merge branch name id: vars run: | @@ -23,7 +23,7 @@ jobs: echo tag=${PACKAGE_VERSION} >> $GITHUB_OUTPUT echo merge_branch_name="dev/merge-${PACKAGE_VERSION}-${COMMIT_HASH}-into-develop" >> $GITHUB_OUTPUT - name: Create merge branch - uses: peterjgrainger/action-create-branch@v2.4.0 + uses: peterjgrainger/action-create-branch@v3.0.0 with: branch: ${{ steps.vars.outputs.merge_branch_name }} env: diff --git a/.github/workflows/third_party_notices_check.yml b/.github/workflows/third_party_notices_check.yml index 82e331c..0df6a51 100644 --- a/.github/workflows/third_party_notices_check.yml +++ b/.github/workflows/third_party_notices_check.yml @@ -17,12 +17,12 @@ jobs: license-check: runs-on: ${{ inputs.environment }} steps: - - uses: actions/setup-node@v3 + - uses: actions/setup-node@v4 with: node-version: 16.x registry-url: 'https://registry.npmjs.org' - run: npm install -g generate-license-file@1 - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: ref: ${{ github.head_ref }} token: ${{ secrets.REPO_SCOPED_TOKEN }} diff --git a/.github/workflows/update_docs.yml b/.github/workflows/update_docs.yml index 783af03..b8f1090 100644 --- a/.github/workflows/update_docs.yml +++ b/.github/workflows/update_docs.yml @@ -15,11 +15,11 @@ jobs: update-docs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: ref: ${{ github.head_ref }} token: ${{ secrets.REPO_SCOPED_TOKEN }} - - uses: actions/setup-node@v3 + - uses: actions/setup-node@v4 with: node-version: 16.x - run: npm ci diff --git a/.github/workflows/version_update.yml b/.github/workflows/version_update.yml index 49c929e..c61f0ca 100644 --- a/.github/workflows/version_update.yml +++ b/.github/workflows/version_update.yml @@ -14,8 +14,8 @@ jobs: update-version: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 - name: update package version id: vars run: | diff --git a/.github/workflows/wcag_test.yml b/.github/workflows/wcag_test.yml index d107fbe..a608c51 100644 --- a/.github/workflows/wcag_test.yml +++ b/.github/workflows/wcag_test.yml @@ -21,10 +21,10 @@ jobs: WCAG-test: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: fetch-depth: ${{ inputs.fetch_depth }} - - uses: actions/setup-node@v3 + - uses: actions/setup-node@v4 with: node-version: 16.x registry-url: 'https://registry.npmjs.org' From 03a28038edcff4a6eac90f6605bc9cc8eddfa8bb Mon Sep 17 00:00:00 2001 From: Jesuye David Date: Tue, 16 Apr 2024 15:33:52 -0400 Subject: [PATCH 4/4] github workflows 5 --- .github/workflows/coverage.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 854b451..0e6be2d 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -96,4 +96,5 @@ jobs: - name: Coveralls uses: coverallsapp/github-action@v2 with: + file: coverage/lcov.info github-token: ${{ secrets.caller_github_token }}