From 08ef478f6486e78bf145df6d1fb4abddbd1ee4e3 Mon Sep 17 00:00:00 2001 From: Ryan Pope Date: Mon, 1 Jul 2024 16:52:39 -0400 Subject: [PATCH] remove temp region field --- package-lock.json | 8 ++++--- .../chat-core-aws-connect/THIRD-PARTY-NOTICES | 2 +- packages/chat-core-aws-connect/package.json | 2 +- .../src/infra/ChatCoreAwsConnectImpl.ts | 23 +++---------------- .../test-browser-esm/package.json | 2 +- 5 files changed, 11 insertions(+), 26 deletions(-) diff --git a/package-lock.json b/package-lock.json index 17f8cd6..1b68b15 100644 --- a/package-lock.json +++ b/package-lock.json @@ -4785,6 +4785,7 @@ "version": "16.4.5", "resolved": "https://registry.npmjs.org/dotenv/-/dotenv-16.4.5.tgz", "integrity": "sha512-ZmdL2rui+eB2YwhsWzjInR8LldtZHGDoQ1ugH85ppHKwpUHL7j7rN0Ti9NCnGiQbhaZ11FpR+7ao1dNsmduNUg==", + "dev": true, "engines": { "node": ">=12" }, @@ -10277,8 +10278,7 @@ "license": "BSD-3-Clause", "dependencies": { "amazon-connect-chatjs": "^2.3.0", - "cross-fetch": "^3.1.5", - "dotenv": "^16.4.5" + "cross-fetch": "^3.1.5" }, "devDependencies": { "@babel/preset-env": "^7.21.5", @@ -10287,8 +10287,10 @@ "@microsoft/api-extractor": "^7.34.8", "@types/jest": "^29.5.1", "@types/node-fetch": "^2.6.4", + "@yext/chat-core": "^0.8.1", "@yext/eslint-config": "^1.0.0", "babel-jest": "^29.5.0", + "dotenv": "^16.4.5", "eslint": "^8.39.0", "generate-license-file": "^1.0.0", "jest": "^29.5.0", @@ -10299,7 +10301,7 @@ "typescript": "^5.0.4" }, "peerDependencies": { - "@yext/chat-core": "^0.8.1" + "@yext/chat-core": "^0.8.2" } }, "packages/chat-core-aws-connect/node_modules/arg": { diff --git a/packages/chat-core-aws-connect/THIRD-PARTY-NOTICES b/packages/chat-core-aws-connect/THIRD-PARTY-NOTICES index 84b1d6b..76befee 100644 --- a/packages/chat-core-aws-connect/THIRD-PARTY-NOTICES +++ b/packages/chat-core-aws-connect/THIRD-PARTY-NOTICES @@ -1,6 +1,6 @@ The following NPM package may be included in this product: - - @yext/chat-core@0.8.1 + - @yext/chat-core@0.8.2 This package contains the following license and notice below: diff --git a/packages/chat-core-aws-connect/package.json b/packages/chat-core-aws-connect/package.json index e222ad6..d3b29ff 100644 --- a/packages/chat-core-aws-connect/package.json +++ b/packages/chat-core-aws-connect/package.json @@ -68,6 +68,6 @@ "dotenv": "^16.4.5" }, "peerDependencies": { - "@yext/chat-core": "^0.8.1" + "@yext/chat-core": "^0.8.2" } } diff --git a/packages/chat-core-aws-connect/src/infra/ChatCoreAwsConnectImpl.ts b/packages/chat-core-aws-connect/src/infra/ChatCoreAwsConnectImpl.ts index 0b7774c..fd63d21 100644 --- a/packages/chat-core-aws-connect/src/infra/ChatCoreAwsConnectImpl.ts +++ b/packages/chat-core-aws-connect/src/infra/ChatCoreAwsConnectImpl.ts @@ -5,20 +5,6 @@ import { EventMap, EventCallback } from "../models/EventCallback"; import { LoggerConfig } from "../models/LoggerConfig"; import "amazon-connect-chatjs"; -// TODO: Remove this type once the region is added to the MessageResponse type in chat-core -type MessageResponseWithRegion = MessageResponse & { - integrationDetails: { - awsConnectHandoff: { - credentials: { - accessKeyId: string; - secretAccessKey: string; - sessionToken: string; - }; - region: string; - }; - }; -}; - /** * The primary class for the chat-core integration with AWS Connect. * @@ -43,11 +29,8 @@ export class ChatCoreAwsConnectImpl implements ChatCoreAwsConnect { return; } - // TODO: Remove this type once the region is added to the MessageResponse type in chat-core - const messageResponse = messageRsp as MessageResponseWithRegion; - const connectionCreds = - messageResponse.integrationDetails?.awsConnectHandoff?.credentials; + messageRsp.integrationDetails?.awsConnectHandoff?.credentials; if (!connectionCreds) { throw new Error( "Integration credentials not specified. Cannot initialize chat session." @@ -60,7 +43,7 @@ export class ChatCoreAwsConnectImpl implements ChatCoreAwsConnect { useDefaultLogger: this.loggerConfig.customizedLogger ? false : true, customizedLogger: this.loggerConfig.customizedLogger, }, - region: messageResponse.integrationDetails.awsConnectHandoff.region, + region: messageRsp.integrationDetails?.awsConnectHandoff?.region, }); this.session = connect.ChatSession.create({ @@ -78,7 +61,7 @@ export class ChatCoreAwsConnectImpl implements ChatCoreAwsConnect { this.setupEventListeners(); this.session.sendMessage({ contentType: "text/plain", - message: messageResponse.notes["conversationSummary"], + message: messageRsp.notes.conversationSummary, }); } diff --git a/packages/chat-core-aws-connect/test-browser-esm/package.json b/packages/chat-core-aws-connect/test-browser-esm/package.json index edd51dd..0aed9e3 100644 --- a/packages/chat-core-aws-connect/test-browser-esm/package.json +++ b/packages/chat-core-aws-connect/test-browser-esm/package.json @@ -12,7 +12,7 @@ "serve": "^14.2.0" }, "dependencies": { - "@yext/chat-core": "^0.8.1", + "@yext/chat-core": "^0.8.2", "@yext/chat-core-aws-connect": "file:..", "dotenv": "^16.0.3" },