From a9cbba1bb858ed71c8d5a87d32dd25f35b134240 Mon Sep 17 00:00:00 2001 From: Oliver Shi Date: Wed, 16 Mar 2022 13:21:14 -0400 Subject: [PATCH 1/5] pass Client-SDK HTTP header This will only work when pointed to the next version of the SDK. J=SLAP-1949 TEST=manual,auto see that the test-site specifies the theme's version in the header create a fresh jambo site using the hitchhiker theme, see the header passed as expected --- hooks/templatedataformatter.js | 4 +++- script/core.hbs | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/hooks/templatedataformatter.js b/hooks/templatedataformatter.js index 3324b6a8a..fd9381390 100644 --- a/hooks/templatedataformatter.js +++ b/hooks/templatedataformatter.js @@ -1,4 +1,5 @@ const getCleanedJamboInjectedData = require('../static/webpack/getCleanedJamboInjectedData'); +const packageJson = require('../package.json'); /** * Formats the data sent to the handlebars templates during Jambo builds. @@ -25,7 +26,8 @@ module.exports = function (pageMetadata, siteLevelAttributes, pageNameToConfig) params: currentLocaleConfig.params || {}, relativePath, env: { - JAMBO_INJECTED_DATA: env.JAMBO_INJECTED_DATA + JAMBO_INJECTED_DATA: env.JAMBO_INJECTED_DATA, + packageJsonVersion: packageJson.version } }; if (globalConfig.useJWT) { diff --git a/script/core.hbs b/script/core.hbs index 03cbeac98..c94204582 100644 --- a/script/core.hbs +++ b/script/core.hbs @@ -18,6 +18,9 @@ {{#with env.JAMBO_INJECTED_DATA}} {{#if businessId}}businessId: "{{businessId}}",{{/if}} {{/with}} + customClientSdk: { + ANSWERS_THEME: '{{{ env.packageJsonVersion }}}' + } }; const userConfig = { {{#with (deepMerge global_config (lookup verticalsToConfig verticalKey) pageSettings) }} From f2df1ac6ca4ad0f7cdf40f318e8eac6b600357c0 Mon Sep 17 00:00:00 2001 From: Oliver Shi Date: Thu, 17 Mar 2022 10:28:20 -0400 Subject: [PATCH 2/5] acceptance tests! --- package-lock.json | 84 +++++++++---------- package.json | 2 +- script/core.hbs | 6 +- test-site/config/global_config.json | 4 +- tests/acceptance/constants.js | 8 +- tests/acceptance/searchrequestlogger.js | 44 ++++++++-- .../suites/client-sdk-http-header.js | 51 +++++++++++ 7 files changed, 139 insertions(+), 60 deletions(-) create mode 100644 tests/acceptance/suites/client-sdk-http-header.js diff --git a/package-lock.json b/package-lock.json index a04a44700..d50ee06c6 100644 --- a/package-lock.json +++ b/package-lock.json @@ -34,7 +34,7 @@ "puppeteer": "^10.2.0", "serve": "^11.3.2", "simple-git": "^2.24.0", - "testcafe": "^1.18.3", + "testcafe": "^1.18.4", "testcafe-browser-provider-browserstack": "^1.13.1", "underscore.string": "^3.3.5", "urijs": "1.18.12", @@ -11007,9 +11007,9 @@ } }, "node_modules/log-update-async-hook": { - "version": "2.0.2", - "resolved": "https://registry.npmjs.org/log-update-async-hook/-/log-update-async-hook-2.0.2.tgz", - "integrity": "sha512-HQwkKFTZeUOrDi1Duf2CSUa/pSpcaCHKLdx3D/Z16DsipzByOBffcg5y0JZA1q0n80dYgLXe2hFM9JGNgBsTDw==", + "version": "2.0.6", + "resolved": "https://registry.npmjs.org/log-update-async-hook/-/log-update-async-hook-2.0.6.tgz", + "integrity": "sha512-UIFPlCpCxrSVL38TXzk34JhhDnvvhsjzuyqooCYy9TtTaVdBLNsuJiTWX9unO/wzBF7RwY1WTCmEmBSI3iPDCA==", "dev": true, "dependencies": { "ansi-escapes": "^2.0.0", @@ -14242,9 +14242,9 @@ } }, "node_modules/testcafe": { - "version": "1.18.3", - "resolved": "https://registry.npmjs.org/testcafe/-/testcafe-1.18.3.tgz", - "integrity": "sha512-cBWPBmY20xI9iWQzS9s2t3oIYhXl5gJzM6CTQjLXt5CMAEvWThsOzLWWnNoA2nk4CLBexZ0S5SkrYOk/SGVSaw==", + "version": "1.18.4", + "resolved": "https://registry.npmjs.org/testcafe/-/testcafe-1.18.4.tgz", + "integrity": "sha512-i/fDhEXtQjQeva4JGLAJpo5J8uEY75ojb3T6Vp8zja3ffvXPwEm2evbfsaGbvGBdPChV+7BFsA0+5js5I81nOQ==", "dev": true, "dependencies": { "@babel/core": "^7.12.1", @@ -14299,7 +14299,7 @@ "is-stream": "^2.0.0", "json5": "^2.1.0", "lodash": "^4.17.13", - "log-update-async-hook": "^2.0.2", + "log-update-async-hook": "^2.0.4", "make-dir": "^3.0.0", "mime-db": "^1.41.0", "moment": "^2.10.3", @@ -14323,7 +14323,7 @@ "source-map-support": "^0.5.16", "strip-bom": "^2.0.0", "testcafe-browser-tools": "2.0.22", - "testcafe-hammerhead": "24.5.13", + "testcafe-hammerhead": "24.5.14", "testcafe-legacy-api": "5.1.2", "testcafe-reporter-dashboard": "0.2.5", "testcafe-reporter-json": "^2.1.0", @@ -14617,9 +14617,9 @@ } }, "node_modules/testcafe-hammerhead": { - "version": "24.5.13", - "resolved": "https://registry.npmjs.org/testcafe-hammerhead/-/testcafe-hammerhead-24.5.13.tgz", - "integrity": "sha512-81P9to2pXBCOy+jnyEaPcjrfKk3wOv7JmZSX3KQp0MxF12X9u6Tg0JEeTMYvnEfCeNhLRYDipAZvI+t9nfx0KA==", + "version": "24.5.14", + "resolved": "https://registry.npmjs.org/testcafe-hammerhead/-/testcafe-hammerhead-24.5.14.tgz", + "integrity": "sha512-0j9HQOOj+O8OzaLUS3Jr9mDxYUu/1PQgadFPVN9ApM7PyM4Yxj5/S0t4RJAulhpK13j9H9kD08TdfGB9H8U5BQ==", "dev": true, "dependencies": { "acorn-hammerhead": "0.5.0", @@ -14644,7 +14644,7 @@ "pinkie": "2.0.4", "read-file-relative": "^1.2.0", "semver": "5.5.0", - "tough-cookie": "2.3.3", + "tough-cookie": "4.0.0", "tunnel-agent": "0.6.0", "webauth": "^1.1.0" }, @@ -14700,12 +14700,6 @@ "integrity": "sha1-DE/EHBAAxea5PUiwP4CDg3g06fY=", "dev": true }, - "node_modules/testcafe-hammerhead/node_modules/punycode": { - "version": "1.4.1", - "resolved": "https://registry.npmjs.org/punycode/-/punycode-1.4.1.tgz", - "integrity": "sha1-wNWmOycYgArY4esPpSachN1BhF4=", - "dev": true - }, "node_modules/testcafe-hammerhead/node_modules/readable-stream": { "version": "2.3.7", "resolved": "https://registry.npmjs.org/readable-stream/-/readable-stream-2.3.7.tgz", @@ -14740,15 +14734,17 @@ } }, "node_modules/testcafe-hammerhead/node_modules/tough-cookie": { - "version": "2.3.3", - "resolved": "https://registry.npmjs.org/tough-cookie/-/tough-cookie-2.3.3.tgz", - "integrity": "sha1-C2GKVWW23qkL80JdBNVe3EdadWE=", + "version": "4.0.0", + "resolved": "https://registry.npmjs.org/tough-cookie/-/tough-cookie-4.0.0.tgz", + "integrity": "sha512-tHdtEpQCMrc1YLrMaqXXcj6AxhYi/xgit6mZu1+EDWUn+qhUf8wMQoFIy9NXuq23zAwtcB0t/MjACGR18pcRbg==", "dev": true, "dependencies": { - "punycode": "^1.4.1" + "psl": "^1.1.33", + "punycode": "^2.1.1", + "universalify": "^0.1.2" }, "engines": { - "node": ">=0.8" + "node": ">=6" } }, "node_modules/testcafe-legacy-api": { @@ -26447,9 +26443,9 @@ } }, "log-update-async-hook": { - "version": "2.0.2", - "resolved": "https://registry.npmjs.org/log-update-async-hook/-/log-update-async-hook-2.0.2.tgz", - "integrity": "sha512-HQwkKFTZeUOrDi1Duf2CSUa/pSpcaCHKLdx3D/Z16DsipzByOBffcg5y0JZA1q0n80dYgLXe2hFM9JGNgBsTDw==", + "version": "2.0.6", + "resolved": "https://registry.npmjs.org/log-update-async-hook/-/log-update-async-hook-2.0.6.tgz", + "integrity": "sha512-UIFPlCpCxrSVL38TXzk34JhhDnvvhsjzuyqooCYy9TtTaVdBLNsuJiTWX9unO/wzBF7RwY1WTCmEmBSI3iPDCA==", "dev": true, "requires": { "ansi-escapes": "^2.0.0", @@ -29032,9 +29028,9 @@ } }, "testcafe": { - "version": "1.18.3", - "resolved": "https://registry.npmjs.org/testcafe/-/testcafe-1.18.3.tgz", - "integrity": "sha512-cBWPBmY20xI9iWQzS9s2t3oIYhXl5gJzM6CTQjLXt5CMAEvWThsOzLWWnNoA2nk4CLBexZ0S5SkrYOk/SGVSaw==", + "version": "1.18.4", + "resolved": "https://registry.npmjs.org/testcafe/-/testcafe-1.18.4.tgz", + "integrity": "sha512-i/fDhEXtQjQeva4JGLAJpo5J8uEY75ojb3T6Vp8zja3ffvXPwEm2evbfsaGbvGBdPChV+7BFsA0+5js5I81nOQ==", "dev": true, "requires": { "@babel/core": "^7.12.1", @@ -29089,7 +29085,7 @@ "is-stream": "^2.0.0", "json5": "^2.1.0", "lodash": "^4.17.13", - "log-update-async-hook": "^2.0.2", + "log-update-async-hook": "^2.0.4", "make-dir": "^3.0.0", "mime-db": "^1.41.0", "moment": "^2.10.3", @@ -29113,7 +29109,7 @@ "source-map-support": "^0.5.16", "strip-bom": "^2.0.0", "testcafe-browser-tools": "2.0.22", - "testcafe-hammerhead": "24.5.13", + "testcafe-hammerhead": "24.5.14", "testcafe-legacy-api": "5.1.2", "testcafe-reporter-dashboard": "0.2.5", "testcafe-reporter-json": "^2.1.0", @@ -30526,9 +30522,9 @@ } }, "testcafe-hammerhead": { - "version": "24.5.13", - "resolved": "https://registry.npmjs.org/testcafe-hammerhead/-/testcafe-hammerhead-24.5.13.tgz", - "integrity": "sha512-81P9to2pXBCOy+jnyEaPcjrfKk3wOv7JmZSX3KQp0MxF12X9u6Tg0JEeTMYvnEfCeNhLRYDipAZvI+t9nfx0KA==", + "version": "24.5.14", + "resolved": "https://registry.npmjs.org/testcafe-hammerhead/-/testcafe-hammerhead-24.5.14.tgz", + "integrity": "sha512-0j9HQOOj+O8OzaLUS3Jr9mDxYUu/1PQgadFPVN9ApM7PyM4Yxj5/S0t4RJAulhpK13j9H9kD08TdfGB9H8U5BQ==", "dev": true, "requires": { "acorn-hammerhead": "0.5.0", @@ -30553,7 +30549,7 @@ "pinkie": "2.0.4", "read-file-relative": "^1.2.0", "semver": "5.5.0", - "tough-cookie": "2.3.3", + "tough-cookie": "4.0.0", "tunnel-agent": "0.6.0", "webauth": "^1.1.0" }, @@ -30600,12 +30596,6 @@ "integrity": "sha1-DE/EHBAAxea5PUiwP4CDg3g06fY=", "dev": true }, - "punycode": { - "version": "1.4.1", - "resolved": "https://registry.npmjs.org/punycode/-/punycode-1.4.1.tgz", - "integrity": "sha1-wNWmOycYgArY4esPpSachN1BhF4=", - "dev": true - }, "readable-stream": { "version": "2.3.7", "resolved": "https://registry.npmjs.org/readable-stream/-/readable-stream-2.3.7.tgz", @@ -30637,12 +30627,14 @@ } }, "tough-cookie": { - "version": "2.3.3", - "resolved": "https://registry.npmjs.org/tough-cookie/-/tough-cookie-2.3.3.tgz", - "integrity": "sha1-C2GKVWW23qkL80JdBNVe3EdadWE=", + "version": "4.0.0", + "resolved": "https://registry.npmjs.org/tough-cookie/-/tough-cookie-4.0.0.tgz", + "integrity": "sha512-tHdtEpQCMrc1YLrMaqXXcj6AxhYi/xgit6mZu1+EDWUn+qhUf8wMQoFIy9NXuq23zAwtcB0t/MjACGR18pcRbg==", "dev": true, "requires": { - "punycode": "^1.4.1" + "psl": "^1.1.33", + "punycode": "^2.1.1", + "universalify": "^0.1.2" } } } diff --git a/package.json b/package.json index 40576b7cc..c5c0a0c76 100644 --- a/package.json +++ b/package.json @@ -47,7 +47,7 @@ "puppeteer": "^10.2.0", "serve": "^11.3.2", "simple-git": "^2.24.0", - "testcafe": "^1.18.3", + "testcafe": "^1.18.4", "testcafe-browser-provider-browserstack": "^1.13.1", "underscore.string": "^3.3.5", "urijs": "1.18.12", diff --git a/script/core.hbs b/script/core.hbs index c94204582..b6ce3594a 100644 --- a/script/core.hbs +++ b/script/core.hbs @@ -18,8 +18,10 @@ {{#with env.JAMBO_INJECTED_DATA}} {{#if businessId}}businessId: "{{businessId}}",{{/if}} {{/with}} - customClientSdk: { - ANSWERS_THEME: '{{{ env.packageJsonVersion }}}' + additionalHttpHeaders: { + 'Client-SDK': { + ANSWERS_THEME: '{{{ env.packageJsonVersion }}}' + } } }; const userConfig = { diff --git a/test-site/config/global_config.json b/test-site/config/global_config.json index 5d9b812f7..071d83e33 100644 --- a/test-site/config/global_config.json +++ b/test-site/config/global_config.json @@ -1,10 +1,10 @@ { - "sdkVersion": "1.12", // The version of the Answers SDK to use + "sdkVersion": "develop", // The version of the Answers SDK to use // "token": "", // The auth token to access Answers experience. "apiKey": "2d8c550071a64ea23e263118a2b0680b", // The answers api key found on the experiences page. This will be provided automatically by the Yext CI system // "experienceVersion": "", // the Answers Experience version to use for API requests. This will be provided automatically by the Yext CI system // "environment": "production", // The environment to run on for this Answers Experience. (i.e. 'production' or 'sandbox') - // "businessId": "", // The business ID of the account. This will be provided automatically by the Yext CI system + "businessId": "3350634", // The business ID of the account. This will be provided automatically by the Yext CI system // "initializeManually": true, // If true, the experience must be started by calling AnswersExperience.init() or AnswersExperienceFrame.init() for iframe integrations. // "useJWT": true, // Whether or not to enable JWT. If true, the apiKey will be hidden from the build and the token must be specified through the runtime config. "sessionTrackingEnabled": true, // Whether or not session tracking is enabled for all pages diff --git a/tests/acceptance/constants.js b/tests/acceptance/constants.js index 349a1d0a1..732dd952c 100644 --- a/tests/acceptance/constants.js +++ b/tests/acceptance/constants.js @@ -1,3 +1,5 @@ -module.exports.PORT=9999; -module.exports.VERTICAL_SEARCH_URL_REGEX=/v2\/accounts\/me\/answers\/vertical\/query/; -module.exports.UNIVERSAL_SEARCH_URL_REGEX=/v2\/accounts\/me\/answers\/query/; +exports.PORT=9999; +exports.VERTICAL_SEARCH_URL_REGEX=/v2\/accounts\/me\/answers\/vertical\/query/; +exports.UNIVERSAL_SEARCH_URL_REGEX=/v2\/accounts\/me\/answers\/query/; +exports.UNIVERSAL_AUTOCOMPLETE_URL_REGEX=/v2\/accounts\/me\/answers\/autocomplete/; +exports.VERTICAL_AUTOCOMPLETE_URL_REGEX=/v2\/accounts\/me\/answers\/vertical\/autocomplete/; diff --git a/tests/acceptance/searchrequestlogger.js b/tests/acceptance/searchrequestlogger.js index f02ddb43d..357fd429d 100644 --- a/tests/acceptance/searchrequestlogger.js +++ b/tests/acceptance/searchrequestlogger.js @@ -1,10 +1,14 @@ -import { VERTICAL_SEARCH_URL_REGEX, UNIVERSAL_SEARCH_URL_REGEX } from './constants'; +import { VERTICAL_SEARCH_URL_REGEX, UNIVERSAL_SEARCH_URL_REGEX, VERTICAL_AUTOCOMPLETE_URL_REGEX, UNIVERSAL_AUTOCOMPLETE_URL_REGEX } from './constants'; import { RequestLogger } from 'testcafe'; +const LOGGER_OPTIONS = { + logRequestHeaders: true +} + /** * Handles request logger creation and request/response data received during test execution. */ -class SearchRequestLogger { +export class SearchRequestLogger { /** * Create a RequestLogger that tracks vertical query requests to given test. @@ -13,8 +17,9 @@ class SearchRequestLogger { */ createVerticalSearchLogger() { this._queryRequestLogger = RequestLogger({ - url: VERTICAL_SEARCH_URL_REGEX - }); + url: VERTICAL_SEARCH_URL_REGEX, + method: 'get' + }, LOGGER_OPTIONS); return this._queryRequestLogger; } @@ -25,8 +30,35 @@ class SearchRequestLogger { */ createUniversalSearchLogger() { this._queryRequestLogger = RequestLogger({ - url: UNIVERSAL_SEARCH_URL_REGEX - }); + url: UNIVERSAL_SEARCH_URL_REGEX, + method: 'get' + }, LOGGER_OPTIONS); + return this._queryRequestLogger; + } + + /** + * Create a RequestLogger that tracks vertical query requests to given test. + * + * @returns {import('testcafe').RequestLogger} + */ + createVerticalAutocompleteLogger() { + this._queryRequestLogger = RequestLogger({ + url: VERTICAL_AUTOCOMPLETE_URL_REGEX, + method: 'get' + }, LOGGER_OPTIONS); + return this._queryRequestLogger; + } + + /** + * Create a RequestLogger that tracks universal query requests to given test. + * + * @returns {import('testcafe').RequestLogger} + */ + createUniversalAutocompleteLogger() { + this._queryRequestLogger = RequestLogger({ + url: UNIVERSAL_AUTOCOMPLETE_URL_REGEX, + method: 'get' + }, LOGGER_OPTIONS); return this._queryRequestLogger; } diff --git a/tests/acceptance/suites/client-sdk-http-header.js b/tests/acceptance/suites/client-sdk-http-header.js new file mode 100644 index 000000000..8f5c6c821 --- /dev/null +++ b/tests/acceptance/suites/client-sdk-http-header.js @@ -0,0 +1,51 @@ +import { PORT, UNIVERSAL_AUTOCOMPLETE_URL_REGEX, UNIVERSAL_SEARCH_URL_REGEX } from '../constants'; +import { SearchRequestLogger } from '../searchrequestlogger'; +import { VERTICAL_SEARCH_URL_REGEX, VERTICAL_AUTOCOMPLETE_URL_REGEX } from '../constants'; +import { registerIE11NoCacheHook } from '../../test-utils/testcafe'; +import packageJson from '../../../package.json'; + +const verticalSearchLogger = (new SearchRequestLogger()).createVerticalSearchLogger(); +const verticalAutocompleteLogger = (new SearchRequestLogger()).createVerticalAutocompleteLogger(); + +fixture`Client-SDK header works on vertical searches/autocomplete` + .page(`http://localhost:${PORT}/people`) + .requestHooks(verticalSearchLogger, verticalAutocompleteLogger) + .beforeEach(async t => { + await registerIE11NoCacheHook(t, VERTICAL_SEARCH_URL_REGEX); + await registerIE11NoCacheHook(t, VERTICAL_AUTOCOMPLETE_URL_REGEX); + await t.resizeWindow(1600, 900); + }) + +test('the Client-SDK header is sent correctly on vertical search/autocomplete requests', async t => { + await t.expect(verticalAutocompleteLogger.requests.length).eql(1); + await t.expect(verticalSearchLogger.requests.length).eql(1); + await t + .expect(verticalAutocompleteLogger.requests[0].request.headers['client-sdk']) + .contains(`ANSWERS_THEME=${packageJson.version}`); + await t + .expect(verticalSearchLogger.requests[0].request.headers['client-sdk']) + .contains(`ANSWERS_THEME=${packageJson.version}`); +}); + +const universalSearchLogger = (new SearchRequestLogger()).createUniversalSearchLogger(); +const universalAutocompleteLogger = (new SearchRequestLogger()).createUniversalAutocompleteLogger(); + +fixture`Client-SDK header works on universal searches/autocomplete` + .page(`http://localhost:${PORT}/index`) + .requestHooks(universalSearchLogger, universalAutocompleteLogger) + .beforeEach(async t => { + await registerIE11NoCacheHook(t, UNIVERSAL_SEARCH_URL_REGEX); + await registerIE11NoCacheHook(t, UNIVERSAL_AUTOCOMPLETE_URL_REGEX); + await t.resizeWindow(1600, 900); + }) + +test('the Client-SDK header is sent correctly on universal search/autocomplete requests', async t => { + await t.expect(universalSearchLogger.requests.length).eql(1); + await t.expect(universalAutocompleteLogger.requests.length).eql(1); + await t + .expect(universalAutocompleteLogger.requests[0].request.headers['client-sdk']) + .contains(`ANSWERS_THEME=${packageJson.version}`); + await t + .expect(universalSearchLogger.requests[0].request.headers['client-sdk']) + .contains(`ANSWERS_THEME=${packageJson.version}`); +}); \ No newline at end of file From 844caf30661c21261058dcf785429dd22782fa6f Mon Sep 17 00:00:00 2001 From: Oliver Shi Date: Thu, 17 Mar 2022 17:53:54 -0400 Subject: [PATCH 3/5] jwt --- hooks/templatedataformatter.js | 1 + 1 file changed, 1 insertion(+) diff --git a/hooks/templatedataformatter.js b/hooks/templatedataformatter.js index fd9381390..d33584e7f 100644 --- a/hooks/templatedataformatter.js +++ b/hooks/templatedataformatter.js @@ -75,6 +75,7 @@ function getCleanedTemplateData(templateData) { apiKey: undefined }, env: { + ...templateData.env, JAMBO_INJECTED_DATA: getCleanedJamboInjectedData(jamboInjectedData) } } From 670530f2a16817e68c216c68ad9a3b55832f0ed4 Mon Sep 17 00:00:00 2001 From: Oliver Shi Date: Thu, 17 Mar 2022 18:00:33 -0400 Subject: [PATCH 4/5] combine imports --- tests/acceptance/suites/client-sdk-http-header.js | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/acceptance/suites/client-sdk-http-header.js b/tests/acceptance/suites/client-sdk-http-header.js index 8f5c6c821..122e21bd2 100644 --- a/tests/acceptance/suites/client-sdk-http-header.js +++ b/tests/acceptance/suites/client-sdk-http-header.js @@ -1,6 +1,12 @@ -import { PORT, UNIVERSAL_AUTOCOMPLETE_URL_REGEX, UNIVERSAL_SEARCH_URL_REGEX } from '../constants'; +import { + PORT, + UNIVERSAL_AUTOCOMPLETE_URL_REGEX, + UNIVERSAL_SEARCH_URL_REGEX, + VERTICAL_SEARCH_URL_REGEX, + VERTICAL_AUTOCOMPLETE_URL_REGEX +} from '../constants'; import { SearchRequestLogger } from '../searchrequestlogger'; -import { VERTICAL_SEARCH_URL_REGEX, VERTICAL_AUTOCOMPLETE_URL_REGEX } from '../constants'; +import { } from '../constants'; import { registerIE11NoCacheHook } from '../../test-utils/testcafe'; import packageJson from '../../../package.json'; From 2bbef442310065ade22585e0541226a0f93da40c Mon Sep 17 00:00:00 2001 From: Oliver Shi Date: Thu, 17 Mar 2022 18:23:50 -0400 Subject: [PATCH 5/5] boop --- tests/acceptance/suites/client-sdk-http-header.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/acceptance/suites/client-sdk-http-header.js b/tests/acceptance/suites/client-sdk-http-header.js index 122e21bd2..321429f29 100644 --- a/tests/acceptance/suites/client-sdk-http-header.js +++ b/tests/acceptance/suites/client-sdk-http-header.js @@ -6,7 +6,6 @@ import { VERTICAL_AUTOCOMPLETE_URL_REGEX } from '../constants'; import { SearchRequestLogger } from '../searchrequestlogger'; -import { } from '../constants'; import { registerIE11NoCacheHook } from '../../test-utils/testcafe'; import packageJson from '../../../package.json'; @@ -37,7 +36,7 @@ const universalSearchLogger = (new SearchRequestLogger()).createUniversalSearchL const universalAutocompleteLogger = (new SearchRequestLogger()).createUniversalAutocompleteLogger(); fixture`Client-SDK header works on universal searches/autocomplete` - .page(`http://localhost:${PORT}/index`) + .page(`http://localhost:${PORT}`) .requestHooks(universalSearchLogger, universalAutocompleteLogger) .beforeEach(async t => { await registerIE11NoCacheHook(t, UNIVERSAL_SEARCH_URL_REGEX);