From 64048d641a32f654468e03fe9a1d47003b9199d2 Mon Sep 17 00:00:00 2001 From: Yegor Bugayenko Date: Sun, 25 Sep 2016 11:05:28 -0700 Subject: [PATCH] #10 forward fix --- src/main/java/io/jare/tk/TkAdd.java | 16 ++++++++++++---- src/test/java/io/jare/smarts/SafeUserTest.java | 2 ++ 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/src/main/java/io/jare/tk/TkAdd.java b/src/main/java/io/jare/tk/TkAdd.java index 06185e2..73eb6ad 100644 --- a/src/main/java/io/jare/tk/TkAdd.java +++ b/src/main/java/io/jare/tk/TkAdd.java @@ -61,16 +61,24 @@ public Response act(final Request req) throws IOException { try { new SafeUser(this.base.user(new RqUser(req).name())).add(name); } catch (final SafeUser.InvalidNameException ex) { - throw new RsForward(new RsFlash(ex)); + throw TkAdd.forward(new RsFlash(ex)); } - return new RsForward( + return TkAdd.forward( new RsFlash( String.format( "domain \"%s\" added", name ) - ), - "/domains" + ) ); } + /** + * Make forward. + * @param rsp Response + * @return Forward + */ + private static RsForward forward(final Response rsp) { + return new RsForward(rsp, "/domains"); + } + } diff --git a/src/test/java/io/jare/smarts/SafeUserTest.java b/src/test/java/io/jare/smarts/SafeUserTest.java index dc12671..a031b01 100644 --- a/src/test/java/io/jare/smarts/SafeUserTest.java +++ b/src/test/java/io/jare/smarts/SafeUserTest.java @@ -62,6 +62,7 @@ public void acceptsValidDomains() throws Exception { * @throws Exception If some problem inside */ @Test + @SuppressWarnings("PMD.AvoidUsingHardCodedIP") public void rejectsInvalidDomains() throws Exception { final User user = new SafeUser(new FkUser()); final String[] domains = { @@ -70,6 +71,7 @@ public void rejectsInvalidDomains() throws Exception { "www-1 .google.com", "google.УА", "www-8=9.google.ua", + "127.0.0.1", }; for (final String domain : domains) { try {