feat: veYFI gauges #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
karelianpie
reviewed
Feb 23, 2023
karelianpie
reviewed
Feb 23, 2023
karelianpie
reviewed
Feb 23, 2023
karelianpie
reviewed
Feb 23, 2023
karelianpie
reviewed
Feb 23, 2023
karelianpie
reviewed
Feb 23, 2023
karelianpie
reviewed
Feb 23, 2023
karelianpie
reviewed
Feb 23, 2023
apps/common/components/Input.tsx
Outdated
| )} | ||
| <div className={'relative flex w-full items-center justify-center'}> | ||
| <input | ||
| className={`h-10 w-full p-2 font-mono text-base font-normal outline-none ${error ? 'border border-solid border-[#EA5204] focus:border-[#EA5204]' : 'border-0 border-none'} ${disabled ? 'bg-neutral-300 text-neutral-600' : 'bg-neutral-0'}`} |
There was a problem hiding this comment.
Do you know if there's a better way to handle these states rather than having all these ternary ops scattered around the className string? Looks hard to read, if there would be a better way that would be great :)
There was a problem hiding this comment.
I have just been adding the dynamically selected classes at the end, but not sure if that is the normal convention with tailwind. Maybe @Majorfi knows best ?
karelianpie
reviewed
Feb 23, 2023
karelianpie
reviewed
Feb 23, 2023
karelianpie
reviewed
Feb 23, 2023
karelianpie
reviewed
Feb 23, 2023
karelianpie
reviewed
Feb 23, 2023
karelianpie
reviewed
Feb 23, 2023
karelianpie
reviewed
Feb 23, 2023
karelianpie
reviewed
Feb 23, 2023
|
👋 Gambito! Is this ready for re-review? |
This was referenced Jun 20, 2023
Merged
|
@xgambitox we could close this, it was successfully merged with |
|
Closing in favor of #248 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):