Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use TNormalizedBN #33

Closed
wants to merge 3 commits into from
Closed

feat: use TNormalizedBN #33

wants to merge 3 commits into from

Conversation

Majorfi
Copy link
Collaborator

@Majorfi Majorfi commented Jan 5, 2023

  • Use TNormalizedBN for the lockAmount state in the LockTab component
  • Change some types from string/number to BigNumber/TNormalizedBN
  • Add a handleInputChangeEventValue event taking directly a string instead of event.target.value. Worth replacing the old one in the future
  • Add DefaultTNormalizedBN to create a 0 TNormalizedBN
  • Add toNormalizedBN to create a TNormalizedBN from a string
  • Extract validateTime from validateAmount and replace types and some checks in validateAmount

@Majorfi Majorfi requested a review from xgambitox January 5, 2023 15:00
@Majorfi Majorfi self-assigned this Jan 5, 2023
@vercel
Copy link

vercel bot commented Jan 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
yearnfi ✅ Ready (Inspect) Visit Preview Jan 5, 2023 at 4:15PM (UTC)

@Majorfi Majorfi marked this pull request as ready for review January 5, 2023 16:12
@Majorfi Majorfi closed this Jan 9, 2023
@Majorfi Majorfi reopened this Jan 9, 2023
@Majorfi Majorfi closed this Jan 9, 2023
Majorfi added a commit that referenced this pull request Sep 20, 2024
@Majorfi
fix: issue #33
ec4e495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgambitox xgambitox Awaiting requested review from xgambitox

Assignees

@Majorfi Majorfi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Majorfi