feat: Migrate GaugesTab to wagmi #258
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
karelianpie
force-pushed
the
feat/veyfi-gauges-merged-gauges-tab
branch
from
def1779
to
4b577f2
Compare
| if(!(props.allowance >= props.amount)) { | ||
| await handleTxWagmi(props, { | ||
| address: props.vaultAddress, | ||
| abi: ['function approve(address _spender, uint256 _value) external'], | ||
| functionName: 'approve', | ||
| args: [props.contractAddress, props.amount] | ||
| }); | ||
| } |
There was a problem hiding this comment.
Should we first refetch allowance here instead of having it as prop?
There was a problem hiding this comment.
Maybe @xgambitox can opinate on this one
There was a problem hiding this comment.
We can, just to make sure the approval tx did not fail for any reason, and throw an error if allowance is still not greater than amount
There was a problem hiding this comment.
As it is right now, if approval tx fails, the stake tx would be prompted to the user as a possible revert through their wallet UI
There was a problem hiding this comment.
Sounds good, created an issue #266
Can add that to the feat/veyfi-gauges-merged branch
|
Migration looks good. If you want to add Major's suggested change here or in other PR is fine by me |
Nice! Let's do it in the branch with all migrations, want to see it green :) |
Last one; Migrate
GaugesTabto wagmi, feature branch of #248